emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#29039: closed (`iter-do' doesn't instrument its bo


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#29039: closed (`iter-do' doesn't instrument its body)
Date: Fri, 03 Nov 2017 13:53:01 +0000

Your message dated Fri, 03 Nov 2017 15:51:51 +0200
with message-id <address@hidden>
and subject line Re: bug#29039: `iter-do' doesn't instrument its body
has caused the debbugs.gnu.org bug report #29039,
regarding `iter-do' doesn't instrument its body
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29039: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29039
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: `iter-do' doesn't instrument its body Date: Sat, 28 Oct 2017 13:07:00 +0200
Attached trivial patch simply adds `(declare (debug ...))' to the
macro. I believe it is perfectly safe and trivial, no mention in NEWS
etc. is needed. I would ask to merge it to branch 26 if possible.

Note that it doesn't quite let you debug generators anyway because of
bug #28725, but the change makes sense regardless. In particular, with
`iter2' package you should be able to debug generator functions called
from `iter-do'.

Paul

Attachment: 0001-Add-missing-debug-declaration-to-iter-do.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#29039: `iter-do' doesn't instrument its body Date: Fri, 03 Nov 2017 15:51:51 +0200
> From: Paul Pogonyshev <address@hidden>
> Date: Sat, 28 Oct 2017 14:48:14 +0200
> Cc: address@hidden
> 
> Because it allows debugging generator functions with `iter2' package.
> `iter2' replaces only `iter-defun' and `iter-lambda', but uses all the
> rest of infrastructure (`iter-yield', `iter-next', `iter-do' and so
> on).
> 
> I'm 100% sure this change cannot break anything in `generator' and is
> logical in itself.

Thanks, pushed.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]