[debbugs-tracker] bug#29030: closed ([PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.)

[GNU bug Tracking System]

Your message dated Sat, 28 Oct 2017 18:29:07 -0500
with message-id <address@hidden>
and subject line Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and 
cpu_clock tests as TODO.
has caused the debbugs.gnu.org bug report #29030,
regarding [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29030: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29030
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO. Date: Fri, 27 Oct 2017 20:40:12 +0000

Hello Guix,

On my system, perl-sys-cpu's tests fail because of differences in the 
information available in /proc/cpuinfo.

Debian's patch for this perl module seemed nice: rather than trying to fix the 
related functions, just concede that the module is mostly used just to read the 
number of available processors and mark the other tests as "TODO".

This patch replaces the test file with debian's using an origin snippet.

Eric Bavier, Scientific Libraries, Cray Inc.

guix-perl-sys-cpu-tests.patch
Description: guix-perl-sys-cpu-tests.patch

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.
>
>
>
>
> Date: 
>
> Sat, 28 Oct 2017 18:29:07 -0500
>
>
>
>
> On Sat, 28 Oct 2017 09:51:24 +0200
> address@hidden (Ludovic Courtès) wrote:
>
> > Hi Eric,
> > 
> > Eric Bavier <address@hidden> skribis:
> > 
> > > On my system, perl-sys-cpu's tests fail because of differences in the 
> > > information available in /proc/cpuinfo.
> > >
> > > Debian's patch for this perl module seemed nice: rather than trying to fix 
> > > the related functions, just concede that the module is mostly used just to 
> > > read the number of available processors and mark the other tests as "TODO". 
> > >  
> > 
> > [...]
> > 
> > > +              (snippet
> > > +               '(begin
> > > +                  ;; Replace test with one that marks cpu_clock and 
> > > cpu_type
> > > +                  ;; as TODO.  Borrowed from Debian.  
> > 
> > Perhaps make it clear in the comment that we do this because the
> > contents of /proc/cpuinfo differ based on different factors.
>
> OK.
>
> > Otherwise LGTM, thanks!
>
> Thanks, pushed in 9de52b56438674c0d0f92be34cebf5f1a38a6bfa.
>
> `~Eric
>
>
> --- End Message ---