[debbugs-tracker] bug#28921: closed ([PROPOSED] Fix xdg timestamp error on 32-bit Emacs)

[GNU bug Tracking System]

Your message dated Sun, 22 Oct 2017 00:41:08 -0700
with message-id <address@hidden>
and subject line Re: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit 
Emacs
has caused the debbugs.gnu.org bug report #28921,
regarding [PROPOSED] Fix xdg timestamp error on 32-bit Emacs
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28921: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28921
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PROPOSED] Fix xdg timestamp error on 32-bit Emacs
>
>
>
>
> Date: 
>
> Fri, 20 Oct 2017 20:04:55 -0700
>
>
>
>
> * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp,
> not an integer.  This avoids signaling an error on 32-bit
> Emacs, where timestamps typically do not fit into fixnums.
> ---
>  lisp/xdg.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/xdg.el b/lisp/xdg.el
> index 76106f4258..6dcef74e4e 100644
> --- a/lisp/xdg.el
> +++ b/lisp/xdg.el
> @@ -93,8 +93,8 @@ xdg-thumb-name
>    (concat (md5 (xdg-thumb-uri filename)) ".png"))
>  
>  (defun xdg-thumb-mtime (filename)
> -  "Return modification time of FILENAME as integral seconds from the epoch."
> -  (floor (float-time (nth 5 (file-attributes filename)))))
> +  "Return modification time of FILENAME as an Emacs timestamp."
> +  (nth 5 (file-attributes filename)))
>  
>  
>  ;; XDG User Directories
> -- 
> 2.13.6
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs
>
>
>
>
> Date: 
>
> Sun, 22 Oct 2017 00:41:08 -0700
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
>
>
>
>
> Tino Calancha wrote:
> > Maybe you could use here the new accesor `file-attribute-modification-time':
>
> Thanks, good idea, I installed it that way into emacs-26. I prefer this to 
> float-time because float-time loses information on platforms like GNU/Linux 
> where typical file timestamps these days have about 61 bits of precision, which 
> is more than the 53 bits that Emacs floats have.
>
>
> --- End Message ---