[debbugs-tracker] bug#28465: closed ([PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files)

[GNU bug Tracking System]

Your message dated Fri, 15 Sep 2017 16:49:24 +0200
with message-id <address@hidden>
and subject line Re: [bug#28465] [PATCH] emacs-emms: Fix metadata retrieval for 
MP3 and FLAC files
has caused the debbugs.gnu.org bug report #28465,
regarding [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28465: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28465
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files Date: Thu, 14 Sep 2017 16:14:37 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hi,

This enhances our emacs-emms package so that it can retrieve the
metadata from FLAC and MP3 files. It also references GNU find
explicitly.

Here's how I tested it:

1. Backup (rename) any existing ~/.emacs.d/emms directory to get rid of
any cached playlist.
2. Make sure you have a collections of a few FLAC, Ogg and MP3 files
under ~/Music.
3. Add the following config to your .emacs file:
--8<---------------cut here---------------start------------->8---
;;; EMMS
(require 'emms-info-metaflac)
(require 'emms-setup)
(emms-all)
(emms-default-players)
(add-to-list 'emms-info-functions #'emms-info-metaflac)
(setq emms-source-file-directory-tree-function
      #'emms-source-file-directory-tree-find)
(setq emms-source-file-default-directory "~/Music/")
--8<---------------cut here---------------end--------------->8---
4. With the patch applied, run:
--8<---------------cut here---------------start------------->8---
./pre-inst-env guix environment --pure --ad-hoc emacs emacs-emms
emacs
--8<---------------cut here---------------end--------------->8---
5. Create the playlist from your default music directory:
M-x emms-add-directory-tree RET ~/Music RET
6. Finally, lauch EMMS with M-x emms and observe that the playlist was
correctly generated based on the files' metadata.

Thank you,

Maxim

0001-gnu-emacs-emms-Fix-metadata-retrieval-for-MP3-and-FL.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#28465] [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files
>
>
>
>
> Date: 
>
> Fri, 15 Sep 2017 16:49:24 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
>
>
>
>
> Maxim Cournoyer <address@hidden> skribis:
>
> > This enhances our emacs-emms package so that it can retrieve the
> > metadata from FLAC and MP3 files. It also references GNU find
> > explicitly.
>
> Nice!
>
> > Here's how I tested it:
>
> I didn’t go through this procedure, but I trust you (and I’ll quickly
> notice if something goes wrong ;-)).
>
> > From fcda96d1469864678ab1f24ec7ba8ee3fa8d28b7 Mon Sep 17 00:00:00 2001
> > From: Maxim Cournoyer <address@hidden>
> > Date: Wed, 13 Sep 2017 17:13:19 -0400
> > Subject: [PATCH] gnu: emacs-emms: Fix metadata retrieval for MP3 and FLAC
> >  files.
> >
> > * gnu/packages/emacs.scm (emacs-emms): Reference find, mpg321 and metaflac by
> > their complete file path.
> > [inputs]: Add flac.
>
> Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---