[debbugs-tracker] bug#28327: closed ([PATCH] gnu: Add emacs-bash-completion.)

[GNU bug Tracking System]

Your message dated Sun, 10 Sep 2017 22:45:31 +0200
with message-id <address@hidden>
and subject line Re: [bug#28327] [PATCH] gnu: Add emacs-bash-completion.
has caused the debbugs.gnu.org bug report #28327,
regarding [PATCH] gnu: Add emacs-bash-completion.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28327: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28327
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add emacs-bash-completion.
>
>
>
>
> Date: 
>
> Sat,  2 Sep 2017 11:11:12 +0200
>
>
>
>
> ---
>  gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 612126eb3..f6165ba54 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -59,6 +59,7 @@
>    #:use-module (guix build-system trivial)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages audio)
> +  #:use-module (gnu packages bash)
>    #:use-module (gnu packages code)
>    #:use-module (gnu packages guile)
>    #:use-module (gnu packages gtk)
> @@ -5444,3 +5445,27 @@ key.  Optionally, a mouse pop-up can be added by binding
>  version of Idris, and some features may rely on the latest Git version of
>  Idris.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-batch-completion
> +  (package
> +    (name "emacs-bash-completion")
> +    (version "20170901.1445")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://melpa.org/packages/bash-completion-";
> +             version
> +             ".tar"))
> +       (sha256
> +        (base32
> +         "12ggygcfhny5sqq18zn6qyyqbh9314niywjagv9nclwxfa0i9pvr"))))
> +    (native-inputs `(("bash" ,bash)))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/szermatt/emacs-bash-completion";)
> +    (synopsis "BASH completion for the shell buffer")
> +    (description
> +     "@code{bash-completion} defines dynamic completion hooks for shell-mode
> +and shell-command prompts that are based on bash completion.
> +")
> +    (license license:gpl3+)))
> -- 
> Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
> Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#28327] [PATCH] gnu: Add emacs-bash-completion.
>
>
>
>
> Date: 
>
> Sun, 10 Sep 2017 22:45:31 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
>
>
>
>
> Alex Kost writes:
>
> >> I have added something here and built package works and looks okay...
> >
> > Now it looks OK for me as well :-)
>
> Good!
>
> > I see that with your patch, 'bash-completion-prog' has the value
> > "/gnu/store/...-bash-4.4.12/bin/bash", so it is definitely 'bash'
> > ('bash-minimal' has "/gnu/store/...-bash-minimal-4.4.12/bin/bash" name).
>
> Also good, thanks for checking.
>
> >> I used guix import elpa --archive=melpa and didn't check.  It seems we
> >> cannot rely on that!
> >
> > We definitely shouldn't rely on it, as the importer always puts 'gpl3+':
> >
> >   http://git.savannah.gnu.org/cgit/guix.git/tree/guix/import/elpa.scm#n234
>
> Great!
>
> > The patch looks good for me, thank you!
>
> Pushed to master as 4aafce22ab74007c69aecc474816d83e64d22646
>
> janneke
>
> -- 
> Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
> Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
>
>
> --- End Message ---