[debbugs-tracker] bug#28217: closed ([PATCH] gnu: hdf4: Avoid unneeded store references to compilers.)

[GNU bug Tracking System]

Your message dated Fri, 01 Sep 2017 09:32:12 +0200 (CEST)
with message-id <address@hidden>
and subject line Re: [bug#28217] [PATCH] gnu: hdf4: Avoid unneeded store 
references to compilers.
has caused the debbugs.gnu.org bug report #28217,
regarding [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28217: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28217
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.
>
>
>
>
> Date: 
>
> Thu, 24 Aug 2017 15:18:54 +0200 (CEST)
>
>
>
>
> Hi,
>
> this patch removes unnecessary references to the C and Fortran 
> compilers from the HDF4 package.
>
> Thomas
>
> >From 6c6c0df09c48c6f2f9b8e77f5e0f88d61f812f3f Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <address@hidden>
> Date: Thu, 24 Aug 2017 14:27:29 +0200
> Subject: [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.
>
> * gnu/packages/maths.scm (hdf4) [arguments]: Add phase 'patch-settings to
>   truncate hashes of compiler store items.
> ---
>  gnu/packages/maths.scm | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 07784defb..16c61dda9 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -605,7 +605,18 @@ computations.")
>                 (("@address@hidden = \
>  -R\\$\\(abs_top_builddir\\)/mfhdf/libsrc/\\.libs \
>  -R\\$\\(abs_top_builddir\\)/hdf/src/\\.libs \\$\\(XDR_ADD\\)") ""))
> -             #t)))))
> +             #t))
> +         (add-after 'configure 'patch-settings
> +           (lambda _
> +             ;; libhdf4.settings contains the full path of the
> +             ;; compilers used, and its contents are included in
> +             ;; .so-files.  We truncate the hashes to avoid
> +             ;; unnecessary store references to those compilers:
> +             (substitute* "libhdf4.settings"
> +               (("(/gnu/store/)([a-Z0-9]*)" all prefix hash)
> +                (string-append prefix (string-take hash 10) "...")))
> +             #t))
> +         )))
>      (home-page "https://www.hdfgroup.org/products/hdf4/";)
>      (synopsis
>       "Library and multi-object file format for storing and managing data")
> -- 
> 2.14.1
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#28217] [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.
>
>
>
>
> Date: 
>
> Fri, 01 Sep 2017 09:32:12 +0200 (CEST)
>
>
>
>
> From: address@hidden (Ludovic Courtès)
> Subject: Re: [bug#28217] [PATCH] gnu: hdf4: Avoid unneeded store 
> references to compilers.
> Date: Thu, 31 Aug 2017 15:00:34 +0200
>
> > I assume hdf4 doesn’t rely on these file names at all for its
> > functionality, right?
>
> No, it's just some extra information.
>
> I pushed this, as well as the hdf5 patches.  Thanks for having a look!
>
> Thomas
>
> --- End Message ---