[debbugs-tracker] bug#28190: closed ([PATCH] gnu: Build the shared library for yaml-cpp.)

[GNU bug Tracking System]

Your message dated Wed, 23 Aug 2017 10:10:11 +0100
with message-id <address@hidden>
and subject line Re: [bug#28190] [PATCH] gnu: Build the shared library for 
yaml-cpp.
has caused the debbugs.gnu.org bug report #28190,
regarding [PATCH] gnu: Build the shared library for yaml-cpp.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28190: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28190
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Build the shared library for yaml-cpp.
>
>
>
>
> Date: 
>
> Tue, 22 Aug 2017 21:36:45 +0100
>
>
>
>
> * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
>   -DBUILD_SHARED_LIBS=ON to #:configure-flags.
> ---
>  gnu/packages/serialization.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
> index 3994191bd..8032e3181 100644
> --- a/gnu/packages/serialization.scm
> +++ b/gnu/packages/serialization.scm
> @@ -249,6 +249,8 @@ that implements both the msgpack and msgpack-rpc 
> specifications.")
>                 (base32
>                  "1vk6pjh0f5k6jwk2sszb9z5169whmiha9ainbdpa1arxlkq7v3b6"))))
>      (build-system cmake-build-system)
> +    (arguments
> +     '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
>      (inputs
>       `(("boost" ,boost)))
>      (native-inputs
> -- 
> 2.14.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#28190] [PATCH] gnu: Build the shared library for yaml-cpp. Date: Wed, 23 Aug 2017 10:10:11 +0100

On Tue, 22 Aug 2017 23:10:38 +0200
Marius Bakke <address@hidden> wrote:

> Christopher Baines <address@hidden> writes:
> 
> > On Tue, 22 Aug 2017 22:58:34 +0200
> > Marius Bakke <address@hidden> wrote:
> >  
> >> Christopher Baines <address@hidden> writes:
> >>   
> >> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
> >> >   -DBUILD_SHARED_LIBS=ON to #:configure-flags.    
> >> 
> >> Does this disable building the static library too?  If not, should
> >> we do that while at it?  LGTM, anyway.  
> >
> > I'm not quite sure, but I think so, these are the files in lib now,
> > and the .a file that was there before has disappeared.
> >
> > └── lib
> >     ├── libyaml-cpp.so -> libyaml-cpp.so.0.5
> >     ├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
> >     ├── libyaml-cpp.so.0.5.3
> >     └── pkgconfig
> >         └── yaml-cpp.pc  
> 
> Great!  Static libraries cannot be reliably grafted, so it's good to
> avoid them when we can.  Thanks!

I've pushed this now, thanks for your review Marius :)

pgpuomEFjEQT1.pgp
Description: OpenPGP digital signature

--- End Message ---