[debbugs-tracker] bug#27811: closed (net-tools patch has no effect?)

[GNU bug Tracking System]

Your message dated Thu, 27 Jul 2017 13:41:58 -0400
with message-id <address@hidden>
and subject line Re: bug#27811: net-tools patch has no effect?
has caused the debbugs.gnu.org bug report #27811,
regarding net-tools patch has no effect?
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27811: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27811
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: net-tools patch has no effect? Date: Mon, 24 Jul 2017 18:02:01 -0400 User-agent: Mutt/1.8.3 (2017-05-23)

While looking into an update of the Debian patch that we apply to
net-tools, I noticed that the patch is not being applied meaningfully.

After the 'patch' phase, there is an empty file called 'the-patch' in
the root of the source tree, but otherwise there are no changes to the
unpacked tarball.

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: bug#27811: net-tools patch has no effect? Date: Thu, 27 Jul 2017 13:41:58 -0400 User-agent: Mutt/1.8.3 (2017-05-23)

On Wed, Jul 26, 2017 at 11:04:54PM +0200, Ludovic Courtès wrote:
> > On Tue, Jul 25, 2017 at 01:52:02PM -0400, Leo Famulari wrote:
> >> From f57732d79ac265917f154da5791ff203c82c9733 Mon Sep 17 00:00:00 2001
> >> From: Leo Famulari <address@hidden>
> >> Date: Tue, 25 Jul 2017 01:46:38 -0400
> >> Subject: [PATCH 2/2] gnu: net-tools: Update to 1.60-0.90da8a0.
> >> 
> >> Fixes <https://bugs.gnu.org/27811>.
> >> 
> >> * gnu/packages/linux.scm (net-tools): Update to 1.60-0.90da8a0.
> >> [inputs]: Remove the Debian patch.
> >> [arguments]: Use modify-phases. Remove the 'patch' phase. Disable
> >> SELINUX and AFBLUETOOTH from build configuration.
> >
> > Revisions!
> >
> > The first patch is the same as before, but the second one uses git-fetch
> > and builds from the latest upstream commit. I'll squash them if we
> > choose to build from Git.
> >
> > From 6cd4159e355b9414b0678608e74fa53b8e173834 Mon Sep 17 00:00:00 2001
> > From: Leo Famulari <address@hidden>
> > Date: Tue, 25 Jul 2017 20:33:27 -0400
> > Subject: [PATCH 1/2] gnu: net-tools: Update to 1.60-0.90da8a0.
> >
> > This leaves net-tools-for-tests unchanged.
> >
> > Fixes <https://bugs.gnu.org/27811>.
> >
> > * gnu/packages/linux.scm (net-tools): Update to 1.60-0.90da8a0.
> > [inputs]: Remove the Debian patch.
> > [arguments]: Use modify-phases. Remove the 'patch' phase. Disable
> > SELINUX and AFBLUETOOTH from build configuration.
> 
> LGTM.  Using ‘git-fetch’ sounds preferable, so better squash both
> patches.
> 
> Thank you!

Pushed as 6d31c175b2e7b062ce71648595c7af2e1381a036.

signature.asc
Description: PGP signature

--- End Message ---