[debbugs-tracker] bug#27710: closed ([PATCH] gnu: address@hidden: Fix test failure.)

[GNU bug Tracking System]

Your message dated Sat, 15 Jul 2017 16:15:42 -0400
with message-id <address@hidden>
and subject line Re: [bug#27710] [PATCH] gnu: address@hidden: Fix test failure.
has caused the debbugs.gnu.org bug report #27710,
regarding [PATCH] gnu: address@hidden: Fix test failure.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27710: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27710
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] gnu: address@hidden: Fix test failure. Date: Sun, 16 Jul 2017 00:59:01 +0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Tags: fixed-upstream
Forwarded: https://github.com/golang/go/issues/20007

Hello,

This patch fixes the test failure in core-updates. I've tried to
cherry-pick upstream's commit, but it doesn't work. So I fall back to
fix it directly instead. The bug has already been fixed upstream, and
the fix will be in the next release (1.9). See [0] for details.

From 023f866f8838df457639a38af9c2c733e445435d Mon Sep 17 00:00:00 2001
From: Alex Vong <address@hidden>
Date: Sun, 16 Jul 2017 00:41:17 +0800
Subject: [PATCH] gnu: address@hidden: Fix test failure.

* gnu/packages/golang.scm (go-1.8)[arguments]: Escape braces in test data in
'prebuild' phase.
---
 gnu/packages/golang.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 70cae6d87..884a49689 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016, 2017 Petter <address@hidden>
 ;;; Copyright © 2016, 2017 Leo Famulari <address@hidden>
 ;;; Copyright © 2017 Sergei Trofimovich <address@hidden>
+;;; Copyright © 2017 Alex Vong <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -296,6 +297,12 @@ sequential processes (CSP) concurrent programming features 
added.")
                  (substitute* "../misc/cgo/testcarchive/carchive_test.go"
                    (("#!/usr/bin/env") (string-append "#!" (which "env"))))
 
+                 ;; escape braces in test data to workaround test failure, see:
+                 ;; https://github.com/golang/go/issues/20007
+                 ;; FIXME: remove this once we upgrade to 1.9
+                 (substitute* "cmd/vet/testdata/copylock_func.go"
+                   (("struct\\{lock sync.Mutex\\}") "struct\\{lock 
sync.Mutex\\}"))
+
                  (substitute* "net/lookup_unix.go"
                    (("/etc/protocols") (string-append net-base 
"/etc/protocols")))
                  (substitute* "net/port_unix.go"
-- 
2.13.3

Cheers,
Alex

[0]: https://github.com/golang/go/issues/20007

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#27710] [PATCH] gnu: address@hidden: Fix test failure. Date: Sat, 15 Jul 2017 16:15:42 -0400 User-agent: Mutt/1.8.3 (2017-05-23)

On Sun, Jul 16, 2017 at 12:59:01AM +0800, Alex Vong wrote:
> Tags: fixed-upstream
> Forwarded: https://github.com/golang/go/issues/20007
> 
> Hello,
> 
> This patch fixes the test failure in core-updates. I've tried to
> cherry-pick upstream's commit, but it doesn't work. So I fall back to
> fix it directly instead. The bug has already been fixed upstream, and
> the fix will be in the next release (1.9). See [0] for details.
> 

> From 023f866f8838df457639a38af9c2c733e445435d Mon Sep 17 00:00:00 2001
> From: Alex Vong <address@hidden>
> Date: Sun, 16 Jul 2017 00:41:17 +0800
> Subject: [PATCH] gnu: address@hidden: Fix test failure.
> 
> * gnu/packages/golang.scm (go-1.8)[arguments]: Escape braces in test data in
> 'prebuild' phase.

Thanks! Pushed as eaca9ff07e4762c3d33e3090bab999c7cf74c98a.

BTW, I've attached an update to the latest Go, 1.9beta2. I can
successfully build Syncthing with it.

0001-WIP-go-Update-to-1.9beta2.patch
Description: Text document

signature.asc
Description: PGP signature

--- End Message ---