[debbugs-tracker] bug#27520: closed ([PATCH] build: Use "GUIXSD" as root label.)

[GNU bug Tracking System]

Your message dated Mon, 10 Jul 2017 15:37:50 +0200
with message-id <address@hidden>
and subject line Re: [bug#27520] [PATCH v2] build, vm: Use "GuixSD" or "GUIXSD" 
as volume label.
has caused the debbugs.gnu.org bug report #27520,
regarding [PATCH] build: Use "GUIXSD" as root label.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27520: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27520
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] build: Use "GUIXSD" as root label.
>
>
>
>
> Date: 
>
> Wed, 28 Jun 2017 23:38:41 +0200
>
>
>
>
> * gnu/build/vm.scm (initialize-hard-disk): Make grub search for label "GUIXSD".
> * gnu/system/install.scm (installation-os): Set filesystem root label to 
> "GUIXSD".
> * gnu/system/vm.scm (system-disk-image): Set filesystem root label to "GUIXSD".
> ---
>  gnu/build/vm.scm       | 2 +-
>  gnu/system/install.scm | 2 +-
>  gnu/system/vm.scm      | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm
> index 57619764c..6b91e767f 100644
> --- a/gnu/build/vm.scm
> +++ b/gnu/build/vm.scm
> @@ -398,7 +398,7 @@ passing it a directory name where it is mounted."
>            (lambda (port)
>              (format port
>                      "insmod part_msdos~@
> -                    search --set=root --label gnu-disk-image~@
> +                    search --set=root --label GUIXSD~@
>                      configfile /boot/grub/grub.cfg~%")))
>  
>          (display "creating EFI firmware image...")
> diff --git a/gnu/system/install.scm b/gnu/system/install.scm
> index 0a78d030d..24c736304 100644
> --- a/gnu/system/install.scm
> +++ b/gnu/system/install.scm
> @@ -300,7 +300,7 @@ Use Alt-F2 for documentation.
>       ;; the appropriate one.
>       (cons* (file-system
>                (mount-point "/")
> -              (device "gnu-disk-image")
> +              (device "GUIXSD")
>                (title 'label)
>                (type "ext4"))
>  
> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
> index 392737d07..6fae999ef 100644
> --- a/gnu/system/vm.scm
> +++ b/gnu/system/vm.scm
> @@ -282,7 +282,7 @@ to USB sticks meant to be read-only."
>      ;; Volume name of the root file system.  Since we don't know which device
>      ;; will hold it, we use the volume name to find it (using the UUID would
>      ;; be even better, but somewhat less convenient.)
> -    "gnu-disk-image")
> +    "GUIXSD")
>  
>    (define file-systems-to-keep
>      (remove (lambda (fs)
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#27520] [PATCH v2] build, vm: Use "GuixSD" or "GUIXSD" as volume label.
>
>
>
>
> Date: 
>
> Mon, 10 Jul 2017 15:37:50 +0200
>
>
>
>
> Hi Ludo,
>
> On Mon, 10 Jul 2017 12:33:39 +0200
> address@hidden (Ludovic Courtès) wrote:
>
> > > +++ b/gnu/build/vm.scm
> > > @@ -431,7 +431,7 @@ passing it a directory name where it is mounted."
> > >            (lambda (port)
> > >              (format port
> > >                      "insmod part_msdos~@
> > > -                    search --set=root --label gnu-disk-image~@
> > > +                    search --set=root --label GuixSD~@
> > >                      configfile /boot/grub/grub.cfg~%")))  
> > 
> > This won’t cause problems with ISO images, right?
>
> Good question.
>
> I successfully tested it in qemu (both iso9660 and normal disk-image).
>
> I also ran the system checks.  Some work, some don't work.  The bootup part 
> does generally work.
>
> But I'm not that knowledgeable with UEFI, so no idea whether ISO9660 bootup 
> would even use this UEFI wrapper thing.
>
> Anyway, it doesn't worsen anything so I pushed it to master, commit 
> 651de2bdb5fd451c50933dcf8d647d470d826261.
>
> Thanks!
>
> P.S. Some system tests look not-so-good either with or without the patch 
> applied:
>
> Jul 10 15:30:54 localhost avahi-daemon[438]: simple-protocol.c: Got 
> RESOLVE-ADDRESS request for 'fe80::5054:ff:fe12:3456'.
> Mon Jul 10 15:30:54 2017 - 341: add new entry "komputilo.local" of type GETAI 
> for hosts to cache (first)
> ice-9/eval.scm:387:11: In procedure eval:
> ice-9/eval.scm:387:11: In procedure getaddrinfo: System error
> ice-9/eval.scm:387:11: In procedure eval:
> ice-9/eval.scm:387:11: In procedure gethost: Host name lookup failure
> QEMU runs as PID 3
> connected to QEMU's monitor
> read QEMU monitor prompt
> connected to guest REPL
> %%%% Starting test avahi  (Writing full log to "avahi.log")
> marionette is ready
> /gnu/store/mw90mh1jb8z4s67k5pi2pk9zid0cqgjl-nss-mdns-builder:1: FAIL 
> getaddrinfo .local
>
> ;;; (gethostbyname #f)
> /gnu/store/mw90mh1jb8z4s67k5pi2pk9zid0cqgjl-nss-mdns-builder:1: FAIL 
> gethostbyname .local
> # of expected passes      3
> # of unexpected failures  2
> note: keeping build directory `/tmp/guix-build-nss-mdns.drv-0'
> builder for `/gnu/store/b4ikx6m6952a5q5hx8576pismks8mq72-nss-mdns.drv' failed 
> with exit code 1
> @ build-failed /gnu/store/b4ikx6m6952a5q5hx8576pismks8mq72-nss-mdns.drv - 1 
> builder for `/gnu/store/b4ikx6m6952a5q5hx8576pismks8mq72-nss-mdns.drv' failed 
> with exit code 1
> TOTAL: 19
> PASS: /gnu/store/jsmkjv57sdycy89whbpj8w0ggzladmy1-basic
> PASS: /gnu/store/i3rpc4na0s8n3ys37qlrzbmsd63g0x4n-mcron
> PASS: /gnu/store/dx2ibskh8a6qirk20n19d5xam2wk3yzy-opensmtpd-test
> PASS: /gnu/store/xgmmghm577xp41w6j1xlzr912x7c1l72-prosody
> PASS: /gnu/store/dl4bjcwwgrrp84mmfm4gcxrp9mfvcwqs-inetd-test
> PASS: /gnu/store/9hg2bp1yk5mdl3wqgfkzvdxm1qmkk6pz-nfs
> PASS: /gnu/store/658s8abgckc4anzlqh9sn17vjhngnyy1-openssh
> PASS: /gnu/store/p6visdc6p4najg7dy4rfpy201136ysn5-dropbear
> PASS: /gnu/store/kynb05cj7kd5kfh9690xwm0i8gvc536z-nginx-test
> FAIL: /gnu/store/90484bwhiizialy1qfvm3gk2fn9r499n-nss-mdns
> FAIL: /gnu/store/csxh0dnpbjqc8q1qkb9j5gbjrlhbpy7v-dicod
> FAIL: /gnu/store/6vp4xg0zzrcz5ksdykd9zr5ydwpvjgvk-btrfs-root-os
> FAIL: /gnu/store/5lw5gfvljp3kkf32k71g2vik258g9jpj-raid-root-os
> FAIL: /gnu/store/n5dq0nx8vgw6ci6wpl7r78bchfs29lfc-installed-os
> FAIL: /gnu/store/bm6n23mp1x74jj57kvy2hlfhi2iyxjhs-encrypted-root-os
> FAIL: /gnu/store/3sjjq1xavrvhkbj7hqbjgvmcmpagmcpz-installed-extlinux-os
> FAIL: /gnu/store/0mj78x3awxwrrjp9s53xgcaa1y5aps8k-separate-store-os
> FAIL: /gnu/store/64wmjlfidh0mzl700zfqmrxmc475vhbk-separate-home-os
> FAIL: /gnu/store/xrbg9b6xc1q26byw0pxi0lk7q58p3z52-exim-test
> make: *** [Makefile:5188: check-system] Error 1
>
> (At the same time, my normal internet connection works fine)
>
>
> --- End Message ---