emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#27331: closed ([PATCH] Handle EIO error in ENOENT-


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#27331: closed ([PATCH] Handle EIO error in ENOENT-safe as well.)
Date: Sun, 11 Jun 2017 21:12:02 +0000

Your message dated Sun, 11 Jun 2017 23:11:16 +0200
with message-id <address@hidden>
and subject line Re: bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well.
has caused the debbugs.gnu.org bug report #27331,
regarding [PATCH] Handle EIO error in ENOENT-safe as well.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27331: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27331
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] Handle EIO error in ENOENT-safe as well. Date: Sun, 11 Jun 2017 13:01:31 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
Trying to boot GuixSD when an audio CD is in the drive will die with an
"input/output error" when trying to read the superblock from the cd
drive.

This patch catches and warns in this case rather than dying.
---
 gnu/build/file-systems.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 08f7d478e..f9cc4088b 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -419,6 +419,10 @@ warning and #f as the result."
                  #f)
                 ((= ENOMEDIUM errno)              ;for removable media
                  #f)
+                ((= EIO errno)                    ;unreadable hardware like 
audio CDs
+                 (format (current-error-port)
+                         "warning: failed to read from device '~a'~%" device)
+                 #f)
                 (else
                  (apply throw args))))))))

--
2.13.1



--- End Message ---
--- Begin Message --- Subject: Re: bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well. Date: Sun, 11 Jun 2017 23:11:16 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
Hello,

Adam Van Ymeren <address@hidden> skribis:

> Trying to boot GuixSD when an audio CD is in the drive will die with an
> "input/output error" when trying to read the superblock from the cd
> drive.
>
> This patch catches and warns in this case rather than dying.

Good catch!  I added a commit log following our conventions and
committed.

Thanks,
Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]