[debbugs-tracker] bug#27238: closed (24.5; Rename `face-spec-set-2' and give it a better doc string)

[GNU bug Tracking System]

Your message dated Sat, 10 Jun 2017 11:41:44 +0300
with message-id <address@hidden>
and subject line Re: bug#27238: 24.5;   Rename `face-spec-set-2' and give it a 
better doc string
has caused the debbugs.gnu.org bug report #27238,
regarding 24.5; Rename `face-spec-set-2' and give it a better doc string
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27238: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27238
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.5; Rename `face-spec-set-2' and give it a better doc string
>
>
>
>
> Date: 
>
> Sun, 4 Jun 2017 10:42:37 -0700 (PDT)
>
>
>
>
> This is a useful, general function, not just a helper.
> Please consider giving it a better name and doc string.
>
> Wrt the doc, the SPEC arg is apparently NOT a face spec, i.e., a spec
> such as is returned by (get FACE 'face-defface-spec).  Instead, it seems
> to be an attributes list such as what is returned by `face-spec-choose'
> or `face-attr-construct'.
>
> In GNU Emacs 24.5.1 (i686-pc-mingw32)
>  of 2015-04-11 on LEG570
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
>  `configure --prefix=/c/usr --host=i686-pc-mingw32'
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#27238: 24.5;	Rename `face-spec-set-2' and give it a better doc string
>
>
>
>
> Date: 
>
> Sat, 10 Jun 2017 11:41:44 +0300
>
>
>
>
> > Date: Mon, 5 Jun 2017 12:36:54 -0700 (PDT)
> > From: Drew Adams <address@hidden>
> > Cc: address@hidden
> > 
> > > The argument received by face-spec-set-2 is just the PLIST
> > > which matches the frame's display, i.e. a simple list.
> > 
> > Yes.  It is not a face spec.  It is a face-attributes plist.
>
> OK, I renamed SPEC to FACE-ATTRS where appropriate, and improved the
> related doc strings.
>
> Thanks.
>
>
> --- End Message ---