[debbugs-tracker] bug#27176: closed ([PATCH] gnu: Add python-xsge.)

[GNU bug Tracking System]

Your message dated Wed, 31 May 2017 20:50:33 -0400
with message-id <address@hidden>
and subject line Re: bug#27176: [PATCH] gnu: Add python-xsge.
has caused the debbugs.gnu.org bug report #27176,
regarding [PATCH] gnu: Add python-xsge.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27176: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27176
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add python-xsge.
>
>
>
>
> Date: 
>
> Wed, 31 May 2017 17:57:44 -0400
>
>
>
>
> * gnu/packages/game-development.scm (python-xsge, python2-xsge): New
> variables.
> ---
>  gnu/packages/game-development.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/game-development.scm 
> b/gnu/packages/game-development.scm
> index b7bcdee94..80f56b245 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -249,6 +249,43 @@ levels.")
>         `(("python2-pathlib" ,python2-pathlib)
>           ,@(package-propagated-inputs python2-tmx))))))
>  
> +(define-public python-xsge
> +  (package
> +    (name "python-xsge")
> +    (version "2017.04.10")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://savannah/xsge/xsge-"
> +                                  version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "04il5yx0py6kchxxw6ydbbx0wpiyjf9dgkwsdynirpkczlnid3am"))))
> +    (build-system python-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (zero?
> +              (system* "python" "setup.py" "install"
> +                       (string-append "--prefix=" (assoc-ref outputs "out"))
> +                       "--root=/")))))
> +       #:tests? #f))
> +    (propagated-inputs
> +     `(("python-sge-pygame" ,python-sge-pygame)
> +       ("python-pygame" ,python-pygame)
> +       ("python-six" ,python-six)
> +       ("python-tmx" ,python-tmx)))
> +    (home-page "http://xsge.nongnu.org";)
> +    (synopsis "Extensions for the SGE Game Engine")
> +    (description
> +     "xSGE is a collection of modules that make doing certain tasks with the 
> SGE
> +Game Engine easier.")
> +    (license license:gpl3+)))
> +
> +(define-public python2-xsge
> +  (package-with-python2 python-xsge))
> +
>  (define-public tiled
>    (package
>      (name "tiled")
> -- 
> 2.13.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#27176: [PATCH] gnu: Add python-xsge. Date: Wed, 31 May 2017 20:50:33 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Danny Milosavljevic <address@hidden> writes:

>> +         (replace 'install
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (zero?
>> +              (system* "python" "setup.py" "install"
>> +                       (string-append "--prefix=" (assoc-ref outputs "out"))
>> +                       "--root=/")))))
>
> What's the difference to what the python-build-system does?

The python-build-system also uses "--single-version-externally-managed"
which is unsupported by xSGE's setup.py script for some reason. I've
added a comment stating this.

>
>> +       #:tests? #f))
>
> Why?
>

I forgot the "no check target" comment, but I've since added it.

>> +    (description
>> +     "xSGE is a collection of modules that make doing certain tasks with 
>> the SGE
>> +Game Engine easier.")
>
> Like what? :)

I added details from the list on the xSGE about page.

>
> Otherwise LGTM!

Pushed to master as e99039b5da6dfbc49a2f8cf0fb523a8049fe5ef8!
Thanks for the review.

signature.asc
Description: PGP signature

--- End Message ---