[debbugs-tracker] bug#27024: closed (25.2: gud.el: wrong menu :visible for pdb)

[GNU bug Tracking System]

Your message dated Sat, 27 May 2017 15:17:00 +0300
with message-id <address@hidden>
and subject line Re: bug#27024: 25.2: gud.el: wrong menu :visible for pdb
has caused the debbugs.gnu.org bug report #27024,
regarding 25.2: gud.el: wrong menu :visible for pdb
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27024: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27024
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.2: gud.el: wrong menu :visible for pdb
>
>
>
>
> Date: 
>
> Mon, 22 May 2017 20:33:26 +0200
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
>
>
>
>
> The "stop" entry in `gud-menu-map' (line 158):
>
>     ([stop]     menu-item "Stop" gud-stop-subjob
>                   :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
>                                (gdb-show-stop-p)))
>
> has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is 
> either
> `gdbmi' or `pdb'.  This function is only related to gdb and isn't loaded 
> by running
> just pdb, so it can cause an error during redisplay (but interestingly,
> it doesn't seem to happen all the time while running pdb -- or maybe the 
> error is
> caught somehow).
>
> Does anyone understand why this check for pdb is here?  It seems to be a 
> mistake,
> but it has been there for more than 7 years...
>
> Otherwise, could someone please remove the check for pdb?  Thanks.
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#27024: 25.2: gud.el: wrong menu :visible for pdb
>
>
>
>
> Date: 
>
> Sat, 27 May 2017 15:17:00 +0300
>
>
>
>
> > From: "Charles A. Roelli" <address@hidden>
> > Date: Mon, 22 May 2017 20:33:26 +0200
> > 
> > The "stop" entry in `gud-menu-map' (line 158):
> > 
> >      ([stop]  menu-item "Stop" gud-stop-subjob
> >                 :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
> >                              (gdb-show-stop-p)))
> > 
> > has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is 
> > either
> > `gdbmi' or `pdb'.  This function is only related to gdb and isn't loaded 
> > by running
> > just pdb, so it can cause an error during redisplay (but interestingly,
> > it doesn't seem to happen all the time while running pdb -- or maybe the 
> > error is
> > caught somehow).
> > 
> > Does anyone understand why this check for pdb is here?  It seems to be a 
> > mistake,
> > but it has been there for more than 7 years...
> > 
> > Otherwise, could someone please remove the check for pdb?  Thanks.
>
> Thanks, I've modified the test to not call gdb-show-stop-p in pdb
> mode.
>
>
> --- End Message ---