[debbugs-tracker] bug#26517: closed ([PATCH] gnu: Add graphene.)

[GNU bug Tracking System]

Your message dated Sat, 15 Apr 2017 21:13:09 -0400
with message-id <address@hidden>
and subject line Re: bug#26517: [PATCH] gnu: Add graphene.
has caused the debbugs.gnu.org bug report #26517,
regarding [PATCH] gnu: Add graphene.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26517: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26517
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] gnu: Add graphene. Date: Sat, 15 Apr 2017 14:35:03 +0200 User-agent: mu4e 0.9.18; emacs 25.1.1

0001-gnu-Add-graphene.patch
Description: Text Data

Dear Guix,

For the new GTK+ release, we need Graphene.  So here is a patch.

Kind regards,
Roel Janssen

--- End Message ---

--- Begin Message --- Subject: Re: bug#26517: [PATCH] gnu: Add graphene. Date: Sat, 15 Apr 2017 21:13:09 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Roel Janssen <address@hidden> writes:

> Dear Kei,
>
> Thanks for your quick response.
>
> Kei Kebreau writes:
>
>> Roel Janssen <address@hidden> writes:
>>
>>>>From 547a9892aa98b65c37e8692f797bd7fbdae6ccc2 Mon Sep 17 00:00:00 2001
>>> From: Roel Janssen <address@hidden>
>>> Date: Sat, 15 Apr 2017 14:33:39 +0200
>>> Subject: [PATCH] gnu: Add graphene.
>>>
>>> * gnu/packages/gtk.scm (graphene): New variable.
>>> ---
>>>  gnu/packages/gtk.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 40 insertions(+)
>>>
>>> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
>>> index 770a8c916..f697e569b 100644
>>> --- a/gnu/packages/gtk.scm
>>> +++ b/gnu/packages/gtk.scm
>>> @@ -42,6 +42,7 @@
>>>    #:use-module (gnu packages)
>>>    #:use-module (gnu packages algebra)
>>>    #:use-module (gnu packages autotools)
>>> +  #:use-module (gnu packages base)
>>>    #:use-module (gnu packages texinfo)
>>>    #:use-module (gnu packages check)
>>>    #:use-module (gnu packages compression)
>>> @@ -1419,3 +1420,42 @@ misspelled words in a GtkTextView widget.")
>>>  thereof, global hotkeys and clipboard item actions.  It was forked from
>>>  Parcellite and adds bugfixes and features.")
>>>      (license license:gpl2+)))
>>> +
>>> +(define-public graphene
>>> +  (package
>>> +    (name "graphene")
>>> +    (version "1.6.0")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri (string-append
>>> +                    "https://github.com/ebassi/graphene/archive/";
>>> +                    version ".tar.gz"))
>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>> +              (sha256
>>> +               (base32 
>>> "1zd2daj7y590wnzn4jw0niyc4fnzgxrcl9i7nwhy8b25ks2hz5wq"))))
>>> +    (build-system gnu-build-system)
>>> +    (arguments
>>> +     `(#:configure-flags '("--enable-introspection=yes")
>>> +       #:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-before 'configure 'autogen
>>> +           (lambda _
>>> +             (zero? (system* "./autogen.sh")))))))
>>> +    (native-inputs
>>> +     `(("autoconf" ,autoconf)
>>> +       ("which" ,which)
>>> +       ("pkg-config" ,pkg-config)
>>> +       ("automake" ,automake)
>>> +       ("libtool" ,libtool)))
>>> +    (inputs
>>> +     `(("python" ,python)
>>> +       ("python-2" ,python-2)
>>> +       ("glib" ,glib)
>>> +       ("gobject-introspection" ,gobject-introspection)))
>>> +    (home-page "http://ebassi.github.io/graphene";)
>>> +    (synopsis "Thin layer of graphic data types")
>>> +    (description "This library provides graphic types and their relative 
>>> API;
>>> +it does not deal with windowing system surfaces, drawing, scene graphs, or
>>> +input.  You're supposed to do that yourself, in your own canvas 
>>> implementation,
>>> +which is the whole point of writing the library in the first place.")
>>
>> The description after "You're supposed to do that yourself..." doesn't
>> seem like it fits in a package description. If you have any other ideas
>> for what information should go there, that'd be great.
>
> Is it okay to remove "You're supposed to ... in the first place."?
>

Sure! I've pushed the patch with this change and added a copyright line
for you.

>>
>>> +    (license license:expat)))
>>
>> Everything else LGTM.
>>
>> P.S.: Where can I find GTK+ documentation about the new Graphene library
>> requirement? Thanks in advance.
>
> So, here's the documentation for the GskRenderer that uses
> 'graphene_rect_t' for example:
>
> https://developer.gnome.org/gsk4/unstable/GskRenderer.html
>
> Thanks for your time!
>

Oooh, I was unaware that there was a GTK4 in development.

> Kind regards,
> Roel Janssen

signature.asc
Description: PGP signature

--- End Message ---