[debbugs-tracker] bug#26191: closed (Allow custom FTP logins.)

[GNU bug Tracking System]

Your message dated Tue, 21 Mar 2017 12:18:40 +0100
with message-id <address@hidden>
and subject line Re: bug#26191: Allow custom FTP logins.
has caused the debbugs.gnu.org bug report #26191,
regarding Allow custom FTP logins.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26191: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26191
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Allow custom FTP logins. Date: Mon, 20 Mar 2017 13:10:08 +0100 User-agent: mu4e 0.9.18; emacs 25.1.1

0001-ftp-client-Allow-custom-username-and-password-for-FT.patch
Description: Text Data

0002-download-Handle-username-and-password-properties-for.patch
Description: Text Data

Dear guix,

These two patches enable the handling of usernames and passwords in a
FTP uri.

Kind regards,
Roel Janssen

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#26191: Allow custom FTP logins.
>
>
>
>
> Date: 
>
> Tue, 21 Mar 2017 12:18:40 +0100
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.1.1
>
>
>
>
> Ludovic Courtès writes:
>
> > Hi Roel,
> >
> > Roel Janssen <address@hidden> skribis:
> >
> >> Ludovic Courtès writes:
> >>
> >>> Roel Janssen <address@hidden> skribis:
> >>>
> >>>> From 8536ba69ec3a04930e8a78c8f2b824df3e8c0454 Mon Sep 17 00:00:00 2001
> >>>> From: Roel Janssen <address@hidden>
> >>>> Date: Mon, 20 Mar 2017 12:57:25 +0100
> >>>> Subject: [PATCH 1/2] ftp-client: Allow custom username and password for FTP
> >>>>  servers.
> >>>>
> >>>> * guix/ftp-client.scm (ftp-open): Add username and password arguments.
> >>>
> >>> OK!
> >>>
> >>>> From e7263ce1d1a242f187c9801b14ea47043f59be8e Mon Sep 17 00:00:00 2001
> >>>> From: Roel Janssen <address@hidden>
> >>>> Date: Mon, 20 Mar 2017 12:59:59 +0100
> >>>> Subject: [PATCH 2/2] download: Handle username and password properties for 
> >>>> FTP
> >>>>  uris.
> >>>>
> >>>> guix/build/download.scm (ftp-fetch): Process username and password from a 
> >>>> URI.
> >>>
> >>> [...]
> >>>
> >>>> +  (let* ((userinfo (string-split (uri-userinfo uri) #\:))
> >>>> +         (username (if (and (> (length userinfo) 0)
> >>>> +                            (not (string= (car userinfo) "")))
> >>>> +                       (car userinfo) #f))
> >>>> +         (password (if (> (length userinfo) 1) (cadr userinfo) #f))
> >>>> +         (conn (ftp-open (uri-host uri) #:timeout timeout
> >>>> +                                        #:username username
> >>>> +                                        #:password password))
> >>>
> >>> Of course I have to agree with Danny here regarding ‘match’.  ;-)
> >>>
> >>>   (let ((user (match userinfo
> >>>                 (() #f)
> >>>                 (("") #f)
> >>>                 (((? string? user)) user)))
> >>>         (pass (match userinfo
> >>>                  …)))
> >>>     …)
> >>>
> >>> OK with a change along these lines.
> >>
> >> I am unsure about this patch (see attached).  Is this what you had in mind?
> >> I would probably have to add a copyright line as well, right?
> >
> > Yes, LGTM!
>
> Ok, thanks!  I pushed the two patches.
>
> Kind regards,
> Roel Janssen
>
>
> --- End Message ---