[debbugs-tracker] bug#22239: closed (fgrep -i slow in 2.21)

[GNU bug Tracking System]

Your message dated Tue, 17 Jan 2017 08:18:30 -0800
with message-id <address@hidden>
and subject line Re: bug#22239: fgrep -i slow in 2.21
has caused the debbugs.gnu.org bug report #22239,
regarding fgrep -i slow in 2.21
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
22239: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22239
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> fgrep -i slow in 2.21
>
>
>
>
> Date: 
>
> Fri, 25 Dec 2015 23:44:42 +0100
>
>
>
>
> When running "grep -Fi -f list.txt" where list.txt has thousands of
> lines, it takes orders of magnitude longer to process the input file
> than without the -i. This was not the case in grep 2.16, where fgrep
> -i was about as fast as fgrep.
>
> --
> Ondřej Cífka
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#22239: fgrep -i slow in 2.21 Date: Tue, 17 Jan 2017 08:18:30 -0800 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 04/11/2016 12:14 AM, Ondřej Cífka wrote:
> You're probably right about the locale. I'm using cs_CZ.UTF-8. With
> LC_ALL=C, both variants run faster and the difference is
> insignificant.
>
> With cs_CZ.UTF-8, on my machine, your test case takes 2.322s with -i
> and 0.464s without -i.
>
> I tested on my Aspell dictionary dump, where the difference is more 
> noticeable:
>
> aspell dump master | head -n 100000 >list.txt
>
> grep 2.21 with -i: 7.336s
> grep 2.21 without -i: 0.312s
> grep 2.16 with -i: 0.372s
> grep 2.16 without -i: 0.431s
>
> With LC_ALL=C, both versions are about as fast.

I got some free time to look into this, and installed the attached set
of patches; the 2nd one is the key one. In the en_EN.utf8 locale on my
platform (Fedora 25 x86-64), I get the following user times for 'grep
-Ff list.txt list.txt' where list.txt was generated as you describe:

   0.444 grep 2.16
   0.522 grep 2.16 -i
   0.443 grep 2.21
  13.048 grep 2.21 -i
   0.096 grep current
   0.101 grep current -i

Since this patch causes grep to use Aho-Corasick more often, I expect it
to hurt performance in some cases involving multiple patterns, but we
can look into that as they turn up. In the meantime since the original
bug seems to be fixed I am taking the liberty of closing the bug report.

0001-build-update-gnulib-submodule-to-latest.txt
Description: Text document

0002-Improve-i-performance-in-typical-UTF-8-searches.txt
Description: Text document

0003-src-kwset.c-Fix-comment-typo.txt
Description: Text document

0004-NEWS-Fix-typo.txt
Description: Text document

--- End Message ---