--- Begin Message ---
Subject: |
ispell.el; cutom setting `ispell-library-directory'; patch |
Date: |
Wed, 14 Sep 2016 23:02:03 +0300 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 |
Hello,
On Windows if one uses cygwin ispell, then one should fix ispell LIBDIR
(which is not correct absolute path) relative to cygwin root by setting
`ispell-library-directory'. Or one also might wish to use custom
location of dictionaries.
Currently ispell.el breaks this possibiliity, because it resets
`ispell-library-directory' to possibly incorrect or unwanted ispell
LIBDIR on every ispell call. Suggested patch attached.
I'm not sure if it doesn't break something (that's why i'm asking in
patch comments), but AFAICS it shouldn't.
Could someone familiar with ispell.el overview and comment on this tiny
patch?
ispell.patch
Description: Text document
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#24439: ispell.el; cutom setting `ispell-library-directory'; patch |
Date: |
Sat, 08 Oct 2016 15:18:36 +0300 |
> From: Agustin Martin <address@hidden>
> Date: Sat, 8 Oct 2016 13:30:50 +0200
> Cc: Laimonas VÄ—bra <address@hidden>
>
> Hi, Eli
>
> I had a look at your patch and it looks really fine, thanks for caring about
> this.
(It's not my patch, it was written by Laimonas.)
> I have also run some tests with it, and seems to work very well regarding
> dictionary selection. Did not check
> actual spellchecking (Checked with an old 24.4.1 where at least a function is
> not available, but could at least
> check that lists of available dictionaries)
Thanks for the review. I pushed this to the master branch (in
Laimonas's name), and I'm marking this bug done.
--- End Message ---