--- Begin Message ---
|
Subject: |
25.0.95; shr-fill-line multiplies the number of images |
|
Date: |
Wed, 20 Jul 2016 19:28:11 +0900 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin) |
Hi,
If `gnus-inhibit-images' is t, shr shows the alt text of an image
in the article buffer. If the alt text is long, `shr-fill-line'
devides it into two or more lines, and each line will get to
have a link to the image individually. In that case, those
number of images will be displayed when a user invokes the WDW
command (gnus-article-show-images) even if there should be only
a single image.
The cause of this problem is that `shr-fill-line' divides not
only the alt text but also the `image-url' text property. So,
I'd like to install the following change. This is the right
fix, isn't it?
Regards,
--- shr.el~ 2016-03-21 22:00:40.983451400 +0000
+++ shr.el 2016-07-20 10:26:30.487350400 +0000
@@ -636,13 +636,12 @@
;; Success; continue.
(when (= (preceding-char) ?\s)
(delete-char -1))
- (let ((face (get-text-property (point) 'face))
+ (let ((props (text-properties-at (point)))
(background-start (point)))
(insert "\n")
(shr-indent)
- (when face
- (put-text-property background-start (point) 'face
- `,(shr-face-background face))))
+ (when props
+ (add-text-properties background-start (point) props)))
(setq start (point))
(shr-vertical-motion shr-internal-width)
(when (looking-at " $")
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#24034: 25.0.95; shr-fill-line multiplies the number of images |
|
Date: |
Thu, 21 Jul 2016 07:57:12 +0900 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin) |
On Wed, 20 Jul 2016 12:31:56 +0200, Lars Ingebrigtsen wrote:
> Katsumi Yamaoka <address@hidden> writes:
>> The cause of this problem is that `shr-fill-line' divides not
>> only the alt text but also the `image-url' text property. So,
>> I'd like to install the following change. This is the right
>> fix, isn't it?
> Yes, I think so.
Done. Thanks.
--- End Message ---