--- Begin Message ---
Subject: |
minor nit: (sxml xpath) node-typeof? |
Date: |
Mon, 29 Dec 2014 17:57:35 -0800 |
In guile-2.0.11 the following appears in sxml/xpath.scm:
(define (node-typeof? crit)
(lambda (node)
(case crit
((*) (and (pair? node) (not (memq (car node) '(@ *PI*)))))
((*any*) #t)
((*text*) (string? node))
(else
(and (pair? node) (eq? crit (car node))))
)))
Would it be more efficient to swap the "(lambda (node)" and "(case crit" forms?
Matt
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#19469: minor nit: (sxml xpath) node-typeof? |
Date: |
Wed, 22 Jun 2016 22:41:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
On Tue 09 Feb 2016 04:58, Matt Wette <address@hidden> writes:
> I recommend that this bug be closed. The current code is fine and consistent
> with the rest of the module. — Matt
OK :) Patches accepted if there are improvements to make :)
A
--- End Message ---