emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#19469: closed (minor nit: (sxml xpath) node-typeof


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#19469: closed (minor nit: (sxml xpath) node-typeof?)
Date: Wed, 22 Jun 2016 20:42:01 +0000

Your message dated Wed, 22 Jun 2016 22:41:00 +0200
with message-id <address@hidden>
and subject line Re: bug#19469: minor nit: (sxml xpath) node-typeof?
has caused the debbugs.gnu.org bug report #19469,
regarding minor nit: (sxml xpath) node-typeof?
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19469: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19469
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: minor nit: (sxml xpath) node-typeof? Date: Mon, 29 Dec 2014 17:57:35 -0800
In guile-2.0.11 the following appears in sxml/xpath.scm:

(define (node-typeof? crit)
  (lambda (node)
    (case crit
      ((*) (and (pair? node) (not (memq (car node) '(@ *PI*)))))
      ((*any*) #t)
      ((*text*) (string? node))
      (else
       (and (pair? node) (eq? crit (car node))))
)))

Would it be more efficient to swap the "(lambda (node)" and "(case crit" forms?

Matt




--- End Message ---
--- Begin Message --- Subject: Re: bug#19469: minor nit: (sxml xpath) node-typeof? Date: Wed, 22 Jun 2016 22:41:00 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
On Tue 09 Feb 2016 04:58, Matt Wette <address@hidden> writes:

> I recommend that this bug be closed.  The current code is fine and consistent 
> with the rest of the module. — Matt

OK :)  Patches accepted if there are improvements to make :)

A


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]