emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#17139: closed (Race condition in complete-in-regio


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#17139: closed (Race condition in complete-in-region: should we be using pre-command-hook, not post-command-hook?)
Date: Sat, 04 Jun 2016 22:18:02 +0000

Your message dated Sat, 4 Jun 2016 18:17:49 -0400
with message-id <address@hidden>
and subject line Re: bug#17139: Race condition in complete-in-region: should we 
be using pre-command-hook, not post-command-hook?
has caused the debbugs.gnu.org bug report #17139,
regarding Race condition in complete-in-region: should we be using 
pre-command-hook, not post-command-hook?
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17139: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17139
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Race condition in complete-in-region: should we be using pre-command-hook, not post-command-hook? Date: Fri, 28 Mar 2014 19:18:04 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
Say we're using a mode derived from comint that implements completion by
using the comint redirection functionality to send commands to the
process associated with the comint buffer. Say we have TAB bound to
complete-symbol. If the user presses TAB (to create a list of
completions) and then immediately presses RET to run comint-send-input,
we send the input to the subprocess, but don't wait for a reply. Then we
run post-command-hook; completion-in-region--postch is on the list of
hooks to run. This function runs completion-in-region-mode--predicate,
which makes a hidden call to the subprocess; this hidden call involves
writing a command waiting for a reply. But because we just sent the
*user* line in comint-send-input, we might actually read the response to
*that* line instead of the internal completion command, causing an
error. The response to the internal completion command then appears in
the comint buffer.

Why can't we do the completion-in-region--postch stuff in pre-command-hook?

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- Subject: Re: bug#17139: Race condition in complete-in-region: should we be using pre-command-hook, not post-command-hook? Date: Sat, 4 Jun 2016 18:17:49 -0400
Closing since this seems to have been resolved.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]