[debbugs-tracker] bug#18147: closed (parted-3.2 build failure)

[GNU bug Tracking System]

Your message dated Thu, 14 Apr 2016 20:47:57 -0400
with message-id <address@hidden>
and subject line Re: bug#18147: parted-3.2 build failure
has caused the debbugs.gnu.org bug report #18147,
regarding parted-3.2 build failure
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18147: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18147
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: parted-3.2 build failure Date: Tue, 29 Jul 2014 22:41:56 +0100 User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0

Hi.

I'm getting the following errors trying to build parted-3.2:

arch/linux.c: In function 'dm_canonical_path':
arch/linux.c:2313:16: warning: implicit declaration of function 
'dm_task_create' [-Wimplicit-function-declaration]
         struct dm_task *task = dm_task_create (DM_DEVICE_INFO);
                ^
arch/linux.c:2313:48: error: 'DM_DEVICE_INFO' undeclared (first use in this 
function)
         struct dm_task *task = dm_task_create (DM_DEVICE_INFO);
                                                ^
arch/linux.c:2313:48: note: each undeclared identifier is reported only once 
for each function it appears in
arch/linux.c:2316:9: warning: implicit declaration of function 
'dm_task_set_major_minor' [-Wimplicit-function-declaration]
         if (!dm_task_set_major_minor (task, arch_specific->major,
         ^
arch/linux.c:2319:9: warning: implicit declaration of function 'dm_task_run' 
[-Wimplicit-function-declaration]
         if (!dm_task_run(task))
         ^
arch/linux.c:2321:9: warning: implicit declaration of function 
'dm_task_get_name' [-Wimplicit-function-declaration]
         char *dev_name = zasprintf ("/dev/mapper/%s", dm_task_get_name (task));
         ^
arch/linux.c:2324:9: warning: implicit declaration of function 
'dm_task_destroy' [-Wimplicit-function-declaration]
         dm_task_destroy (task);
         ^
arch/linux.c: In function '_disk_sync_part_table':
arch/linux.c:2949:33: error: '_dm_add_partition' undeclared (first use in this 
function)
                 add_partition = _dm_add_partition;
                                 ^
arch/linux.c:2950:36: error: '_dm_remove_partition' undeclared (first use in 
this function)
                 remove_partition = _dm_remove_partition;
                                    ^
arch/linux.c:2951:36: error: '_dm_resize_partition' undeclared (first use in 
this function)
                 resize_partition = _dm_resize_partition;
                                    ^
arch/linux.c:2952:50: error: '_dm_get_partition_start_and_length' undeclared 
(first use in this function)
                 get_partition_start_and_length = 
_dm_get_partition_start_and_length;
                                                  ^
I am passing --disable-device-mapper to configure, but the code causing the 
errors is not guarded by #ifdef
ENABLE_DEVICE_MAPPER.

The attached patch allows the build to succeed. I think the resultant code is 
functionally correct, but I'm sure you
will check that :-)

Regards.

Chris

parted-3.2-device-mapper.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18147: parted-3.2 build failure
>
>
>
>
> Date: 
>
> Thu, 14 Apr 2016 20:47:57 -0400
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
>
>
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Looks like this was fixed a while back:
>
> commit a3877115f1956949096d77aca5a703a47ed68397
> Author: Felix Janda <address@hidden>
> Date:   Sun May 3 10:33:31 2015 +0200
>
>     libparted/fs/xfs/platform_defs.h: Include <fcntl.h> for loff_t
>
>     This is needed for compilation with musl libc
>
>     Suggested-by: Travis Tilley <address@hidden>
>
>     Signed-off-by: Brian C. Lane <address@hidden>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQEcBAEBCgAGBQJXEDo9AAoJEBB5UWFcu6UWrbAIAI/YxgcHYKuhEysX5D47fxqN
> n3ewzkH4N0z9Hw7ViW5EdgiDrRp7r6GmYK/TxgzsowvA/t8Td4FqdrgrFRdgRk70
> apK3GxgpeIuZN/ClQqkcNcXFKYQOXSep61WDVcaOjAnAmNIPH1qessA+RzziSEGm
> fdErrg+CHnW5a/XPazQLDc6XEqiAioLZCnJ0vFTInZYuKSQXyoLPaeeHHhXPfwJ+
> KPWQw38No1cEt1jTG+iyc2oR5t+Nv6qZDmRSQ22p6uvCXosgM5VGDJmI3sauN9Al
> 8Oy7rsrmatlRTb2GeIp15Xa3ehoAQ1P9ydq5JVL39ANngYSvAPRmv1A94O8eBcU=
> =cYtt
> -----END PGP SIGNATURE-----
>
>
> --- End Message ---