[debbugs-tracker] bug#22086: closed (25.1.50; [PATCH] Integrate the musl hybrid malloc patch for elf systems)

[GNU bug Tracking System]

Your message dated Sat, 30 Jan 2016 16:43:28 -0800
with message-id <address@hidden>
and subject line Re: bug#22086: 25.1.50; [PATCH] Integrate the musl hybrid mallo
has caused the debbugs.gnu.org bug report #22086,
regarding 25.1.50; [PATCH] Integrate the musl hybrid malloc patch for elf 
systems
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
22086: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22086
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 25.1.50; [PATCH] Integrate the musl hybrid malloc patch for elf systems Date: Thu, 03 Dec 2015 18:57:47 +0100 User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (berkeley-unix)

In the thread around

http://permalink.gmane.org/gmane.emacs.devel/182469

Rich Felker announced that he had found that a small addition to
unexelf.c allowed emacs to extend its hybrid malloc implementation
(previously only used for cygwin) to musl libc, but without using
features specific to that malloc implementation.

A corresponding patch was tested in the "Alpine Linux" distribution, see

http://git.alpinelinux.org/cgit/aports/plain/testing/emacs/musl.patch?id=d6f211ec868df4657c745b8ba2bae77b2a7fb7f6

This patch series proposes the relevant part of that change and adds
some (rather trivial) groundwork to make it reliably work on all systems
which use unexelf.c for dumping.

Personally, I've been using hybrid malloc on top of the libc malloc
(jemalloc) on FreeBSD 10 for several months now without problems.

I also tested it with other malloc libraries, in particular some of
those derived from Doug Lea's malloc.  It also works on GNU/Linux, on
top of glibc.  This might be of some interest as, IIRC, some glibc
people were not too happy about keeping malloc_get_state and stuff.

If you get an error about exceeding "static heap size" during dumping
just bump STATIC_HEAP_SIZE in src/sheap.c a bit.

If the commit messages in the following patches don't explain enough,
please ask.  Also, please apply the patch from

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22085

beforehand.

0002-For-HYBRID_MALLOC-give-most-gmalloc-symbols-internal.patch
Description: Keep gmalloc symbols internal

0003-Link-temacs-with-gnulib-objects-compiled-with-Demacs.patch
Description: Compile separate gnulib.a for emacs with -Demacs

0004-Add-musl-patch-to-support-HYBRID_MALLOC-on-elf-syste.patch
Description: The patch from musl, essentially

0005-configure.ac-Stop-using-mmap-for-buffers-for-FreeBSD.patch
Description: No special case for FreeBSD wrt mmap

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#22086: 25.1.50; [PATCH] Integrate the musl hybrid mallo
>
>
>
>
> Date: 
>
> Sat, 30 Jan 2016 16:43:28 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
>
>
>
>
> Eli Zaretskii wrote:
> > I think
> > when the time comes you should commit this to the master branch, not
> > to emacs-25.
>
> I think it's ready enough for the master branch, so I committed it there and 
> will mark this bug as done.
>
> I had to do a merge first, which was pretty painful, but that should be a 
> different thread.
>
>
>
>
> --- End Message ---