[debbugs-tracker] bug#20450: closed (coreutils cannot built with clang)

[GNU bug Tracking System]

Your message dated Tue, 28 Apr 2015 23:24:22 +0100
with message-id <address@hidden>
and subject line Re: bug#20450: coreutils cannot built with clang
has caused the debbugs.gnu.org bug report #20450,
regarding coreutils cannot built with clang
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
20450: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20450
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: coreutils cannot built with clang Date: Tue, 28 Apr 2015 12:38:53 -0700

Hi, 

   When I try to use clang to build coreutils, I got some thing like

src/coreutils.c:81:3:   AR       src/libsinglebin_printenv.a
error: embedding a #include directive within macro arguments is not supported
# include "coreutils.h"
  ^

And I have the following ugly patch to make it work.

Thanks

---
 src/coreutils.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/coreutils.c b/src/coreutils.c
index 9f798b8..c46f0c7 100644
--- a/src/coreutils.c
+++ b/src/coreutils.c
@@ -70,15 +70,22 @@ Execute the PROGRAM_NAME built-in program with the given PARAMETERS.\n\
       fputs (HELP_OPTION_DESCRIPTION, stdout);
       fputs (VERSION_OPTION_DESCRIPTION, stdout);

-      printf ("\n\
-Built-in programs:\n"
 #ifdef SINGLE_BINARY
 /* XXX: Ideally we#d like to present "install" here, not "ginstall".  */
+      const char * prog_list_name =
 # define SINGLE_BINARY_PROGRAM(prog_name_str, main_name) " " prog_name_str
 # include "coreutils.h"
 # undef SINGLE_BINARY_PROGRAM
+       ;
+#endif
+
+      printf ("\n\
+Built-in programs:\n");
+
+#ifdef SINGLE_BINARY
+      printf("%s", prog_list_name);
 #endif
-  "\n");
+      printf("\n");

       printf (_("\
 \n\
-- 
2.2.0.rc0.207.ga3a616c

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#20450: coreutils cannot built with clang
>
>
>
>
> Date: 
>
> Tue, 28 Apr 2015 23:24:22 +0100
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
>
>
>
>
> On 28/04/15 20:38, Yunlian Jiang wrote:
> > Hi, 
> > 
> >    When I try to use clang to build coreutils, I got some thing like
> > 
> > src/coreutils.c:81:3:   AR       src/libsinglebin_printenv.a
> > error: embedding a #include directive within macro arguments is not supported
> > # include "coreutils.h"
> >   ^
> > 
> > And I have the following ugly patch to make it work.
>
> I can't reproduce with clang 3.5 on Fedora 22 here,
> but yes this will be an issue anywhere printf is a macro.
> I'll apply something like this fix in your name.
>
> thanks!
> Pádraig.
>
>
>
> --- End Message ---