[debbugs-tracker] bug#19641: closed ('guix environment' sometimes incorrectly handles inputs)

[GNU bug Tracking System]

Your message dated Sun, 08 Feb 2015 19:22:37 +0100
with message-id <address@hidden>
and subject line Re: bug#19641: guix environment
has caused the debbugs.gnu.org bug report #19641,
regarding 'guix environment' sometimes incorrectly handles inputs
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19641: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19641
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: guix environment
>
>
>
>
> Date: 
>
> Tue, 20 Jan 2015 22:43:44 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
>
>
>
>
> Federico Beffa <address@hidden> skribis:
>
> > I believe that "guix environment" does not consider all outputs
> > properly. As one example, when I execute:
> >
> > guix environment libpeas
> >
> > the $PATH doesn't include /gnu/store/...glib-2.42.1-bin/bin where
> > ("glib:bin" ,glib "bin") is one of the native-inputs of the package.
> >
> > Is this intentional?
>
> I don’t think so.
>
> On closer inspection, I see two issues:
>
>   (define (packages->transitive-inputs packages)
>     "Return a list of the transitive inputs for all PACKAGES."
>     (define (transitive-inputs package)
>       (filter-map (match-lambda
>                    ((_ (? package? package)) package)
>                    (_ #f))    ; <---- !
>                   (bag-transitive-inputs
>                    (package->bag package))))
>     (delete-duplicates
>      (append-map transitive-inputs packages)))
>
> Here only inputs of the form ("foo" PKG) are considered; things like
> ("glib" ,glib "bin") are discarded.
>
>   (define (for-each-search-path proc inputs derivations pure?)
>     (let ((paths (map derivation->output-path derivations))) ; <-- !
>       [...]
>
> Above, ‘derivation->output-path’ considers only the “out” output,
> ignoring others if they are needed.
>
> I think these would need to be adjusted.  Any takers?  :-)
>
> Ludo’.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#19641: guix environment
>
>
>
>
> Date: 
>
> Sun, 08 Feb 2015 19:22:37 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
>
>
>
>
> AFAIK the problem that Federico reported is fixed by 4b7ad2e3, so I’m
> closing this bug, and opening a new one for the other issue I raised.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---