[debbugs-tracker] bug#18599: closed (erc-input-ring-setup: do not reset the ring when there already is one)

[GNU bug Tracking System]

Your message dated Fri, 21 Nov 2014 19:31:24 +0000
with message-id <address@hidden>
and subject line Re: bug#18599: erc-input-ring-setup: do not reset the ring 
when there already is one 
has caused the debbugs.gnu.org bug report #18599,
regarding erc-input-ring-setup: do not reset the ring when there already is one
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18599: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18599
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> erc-input-ring-setup: do not reset the ring when there already is one
>
>
>
>
> Date: 
>
> Thu, 02 Oct 2014 05:11:03 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
>
>
>
>
> Package: emacs
> X-Debbugs-Cc: address@hidden, Kashish Sharma <address@hidden>
>
> >>>>> Kashish Sharma <address@hidden> writes:
>
> […]
>
>  > 2. (what seems like another bug -) Input history is lost if one
>  > disconnects/reconnects.
>
>         Please consider the patch MIMEd.
>
>         (This one was also recently pointed out on IRC, BTW.)
>
>  > Wishlist - input history remembered across Emacs sessions.  Perhaps
>  > with the option of setting the history size.
>
> […]
>
> -- 
> FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
>
> --- a/lisp/erc/erc-ring.el
> +++ b/lisp/erc/erc-ring.el
> @@ -67,7 +67,8 @@
>  (defun erc-input-ring-setup ()
>    "Do the setup required so that we can use comint style input rings.
>  Call this function when setting up the mode."
> -  (setq erc-input-ring (make-ring comint-input-ring-size))
> +  (unless (ring-p erc-input-ring)
> +    (setq erc-input-ring (make-ring comint-input-ring-size)))
>    (setq erc-input-ring-index nil))
>  
>  (defun erc-add-to-input-ring (s)
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18599: erc-input-ring-setup: do not reset the ring when there already is one 
>
>
>
>
> Date: 
>
> Fri, 21 Nov 2014 19:31:24 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
>
>
>
>
> Version: 24.5
>
>         I no longer observe the issue (as of 2014-11-18 build,
>         cb4f666ade76.)  Per my reading of the Git log, it was fixed in
>         Git master back this October:
>
> commit 3af2917c91e4eb863e1cec92a68ccb3acf940dae
> Author:     Ivan Shmakov <address@hidden>
> AuthorDate: Thu Oct 2 07:31:56 2014 -0400
> Commit:     Kelvin White <address@hidden>
> CommitDate: Thu Oct 2 07:31:56 2014 -0400
>
>     Do not reset input ring if one exists
>     
>     Fixes: debbugs:18599
>
>         In emacs-24, this bug was fixed as part of the following
>         “backport” change:
>
> commit d1036d288de1e047f7f6043188a1063f0d6b044d
> Author:     l3thal <address@hidden>
> AuthorDate: Sat Nov 8 20:51:43 2014 -0500
> Commit:     l3thal <address@hidden>
> CommitDate: Sat Nov 8 20:51:43 2014 -0500
>
>     backport: erc bugfixes
>
> -- 
> FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
>
>
> --- End Message ---