[debbugs-tracker] bug#18898: closed (Two portability patches)

[GNU bug Tracking System]

Your message dated Wed, 12 Nov 2014 00:59:10 -0500
with message-id <address@hidden>
and subject line Re: bug#18898: Two portability patches
has caused the debbugs.gnu.org bug report #18898,
regarding Two portability patches
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18898: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18898
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Two portability patches Date: Thu, 30 Oct 2014 00:36:08 +0100

Hi!

The attached patches against git as of right-now fix two issues:

1.

test does not generally support '==' as comparison operator.
    
It's a bash(1) feature; not even GNU coreutils test(1) supports it.
Use '=' instead.


2.

NetBSD provides newlocale and strcoll_l, but not uselocale.

Please merge them.

Thanks,
 Thomas

0002-test-does-not-generally-support-as-comparison-operat.patch
Description: Text document

0001-NetBSD-provides-newlocale-and-strcoll_l-but-not-usel.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18898: Two portability patches
>
>
>
>
> Date: 
>
> Wed, 12 Nov 2014 00:59:10 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
>
>
>
>
> Thomas Klausner <address@hidden> writes:
>
> > test does not generally support '==' as comparison operator.
> >     
> > It's a bash(1) feature; not even GNU coreutils test(1) supports it.
> > Use '=' instead.
>
> Fixed in 03242f398f3520b1b27caf5885c8d5600094f944.
>
> > NetBSD provides newlocale and strcoll_l, but not uselocale.
>
> Fixed in 30c5982a9548a0ca0ea46111beb490f06d74a40a.
>
> FYI, the patch you provided was not sufficient, because it neglected to
> arrange for HAVE_USELOCALE to be set by configure.  This meant that the
> thread-aware locale API would _never_ be used.
>
> These commits are on the stable-2.0 branch and will be included in Guile
> 2.0.12.  I'm closing this bug now.
>
>      Thanks,
>        Mark
>
>
> --- End Message ---