emacs-bug-tracker
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#18936: closed (ERC: lexical-binding in 24.4 breaks

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#18936: closed (ERC: lexical-binding in 24.4 breaks erc-send-pre-hook)
Date: Tue, 04 Nov 2014 20:10:02 +0000 
Your message dated Tue, 04 Nov 2014 15:08:57 -0500
with message-id <address@hidden>
and subject line Re: bug#18936: ERC: lexical-binding in 24.4 breaks 
erc-send-pre-hook
has caused the debbugs.gnu.org bug report #18936,
regarding ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18936: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18936
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook Date: Mon, 03 Nov 2014 10:00:46 -0500 
>From erc.el, erc-send-pre-hook documentation:

"To change the text that will be sent, set the variable STR which is
used in `erc-send-current-line'."

>From erc.el:5272, function `erc-send-input'

    (let ((str input)
          (erc-insert-this t))
      (setq erc-send-this t)
      (run-hook-with-args 'erc-send-pre-hook input)

STR is dynamically bound.

--- End Message ---
--- Begin Message --- Subject: Re: bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook Date: Tue, 04 Nov 2014 15:08:57 -0500 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) 
> From erc.el, erc-send-pre-hook documentation:
> "To change the text that will be sent, set the variable STR which is
> used in `erc-send-current-line'."

Indeed.  I installed the patch below which should fix it.


        Stefan


=== modified file 'lisp/erc/erc.el'
--- lisp/erc/erc.el     2014-02-10 01:34:22 +0000
+++ lisp/erc/erc.el     2014-11-04 20:06:00 +0000
@@ -5268,6 +5268,7 @@
       (beep))
     nil)
    (t
+    (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention.
     (let ((str input)
          (erc-insert-this t))
       (setq erc-send-this t)

--- End Message ---
reply via email to
[Prev in Thread] Current Thread [Next in Thread]