emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#18603: closed (eww fails to recognize URIs with IP


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#18603: closed (eww fails to recognize URIs with IPv6 addresses in them )
Date: Sun, 02 Nov 2014 21:42:02 +0000

Your message dated Sun, 02 Nov 2014 16:41:20 -0500
with message-id <address@hidden>
and subject line Re: bug#18603: eww fails to recognize URIs with IPv6 addresses 
in them
has caused the debbugs.gnu.org bug report #18603,
regarding eww fails to recognize URIs with IPv6 addresses in them 
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18603: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18603
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: eww fails to recognize URIs with IPv6 addresses in them Date: Thu, 02 Oct 2014 09:37:49 +0000 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Package:  emacs
Severity: normal

        As of 94758757dfd5, the ‘eww’ function uses the presence of a
        full stop character in its ‘url’ argument as one of the
        conditions to consider the value a URI proper (as opposed to:
        keywords to pass to the search engine, as per
        eww-search-prefix.)

        This, however, fails, as IPv6 addresses are colon-delimited, and
        thus IPv6-based URLs do not usually contain any full stop
        characters (as in: https://[::1]/.)

        Please thus consider the trivial patch MIMEd, which makes EWW
        use ‘[.:]’ (was: ‘\.’) as the respective RE.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -154,7 +154,7 @@ defun eww (url)
         (t
          (if (and (= (length (split-string url)) 1)
                  (or (and (not (string-match-p "\\`[\"\'].*[\"\']\\'" url))
-                          (> (length (split-string url "\\.")) 1))
+                          (> (length (split-string url "[.:]")) 1))
                      (string-match eww-local-regex url)))
              (progn
                (unless (string-match-p "\\`[a-zA-Z][-a-zA-Z0-9+.]*://" url)

--- End Message ---
--- Begin Message --- Subject: Re: bug#18603: eww fails to recognize URIs with IPv6 addresses in them Date: Sun, 02 Nov 2014 16:41:20 -0500 User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux)
On Thu, 02 Oct 2014 09:37:49 +0000 Ivan Shmakov <address@hidden> wrote: 
IS>     Please thus consider the trivial patch MIMEd, which makes EWW
IS>     use ‘[.:]’ (was: ‘\.’) as the respective RE.

This works and looks good, so I applied it.  Closing.  Thanks!

Ted


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]