emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#18834: closed (references to (long time removed) e


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#18834: closed (references to (long time removed) eww-quit )
Date: Sun, 02 Nov 2014 21:04:02 +0000

Your message dated Sun, 02 Nov 2014 16:03:57 -0500
with message-id <address@hidden>
and subject line Re: bug#18834: references to (long time removed) eww-quit
has caused the debbugs.gnu.org bug report #18834,
regarding references to (long time removed) eww-quit 
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18834: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18834
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: references to (long time removed) eww-quit Date: Sat, 25 Oct 2014 16:47:43 +0000 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Package:  emacs
Severity: minor
Tags:     patch

        Git records show eww-quit and eww-exit being defined and
        redefined the last December.  Ultimately, however, both of these
        commands were removed from the code, – yet the references to
        them remain there to this day.

        Please thus consider the (untested) patch MIMEd, which is
        intended to complete the following change:

commit 4c004eaa87a1c9771a3ad07b382efbb81e380f96
Author:     Lars Magne Ingebrigtsen <address@hidden>
AuthorDate: Sun Dec 1 18:00:04 2013 +0100

    eww: Have `q' do a normal `quit-window' instead of killing the buffer.

        TIA.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
--- eww.el
+++ eww.el
@@ -443,7 +443,7 @@
 
     (easy-menu-define nil map ""
       '("Eww"
-       ["Exit" eww-quit t]
+       ["Exit" quit-window t]
        ["Close browser" quit-window t]
        ["Reload" eww-reload t]
        ["Back to previous page" eww-back-url
@@ -463,7 +463,7 @@
 (defvar eww-tool-bar-map
   (let ((map (make-sparse-keymap)))
     (dolist (tool-bar-item
-             '((eww-quit . "close")
+             '((quit-window . "close")
                (eww-reload . "refresh")
                (eww-back-url . "left-arrow")
                (eww-forward-url . "right-arrow")

--- End Message ---
--- Begin Message --- Subject: Re: bug#18834: references to (long time removed) eww-quit Date: Sun, 02 Nov 2014 16:03:57 -0500 User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux)
On Sat, 25 Oct 2014 16:47:43 +0000 Ivan Shmakov <address@hidden> wrote: 

IS> -   ["Exit" eww-quit t]
IS> +   ["Exit" quit-window t]
IS> -             '((eww-quit . "close")
IS> +             '((quit-window . "close")

Thanks for the patch; applied in your name.  Closing.

Ted


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]