[debbugs-tracker] bug#18474: closed (trunk; Warning in callproc.c while building for Mac OS X on trunk)

[GNU bug Tracking System]

Your message dated Sun, 14 Sep 2014 10:24:43 +0200
with message-id <address@hidden>
and subject line Re: bug#18474: trunk; Warning in callproc.c while building for 
Mac OS X on trunk
has caused the debbugs.gnu.org bug report #18474,
regarding trunk; Warning in callproc.c while building for Mac OS X on trunk
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18474: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18474
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: trunk; Warning in callproc.c while building for Mac OS X on trunk Date: Sat, 13 Sep 2014 22:55:09 -0700 User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:32.0) Gecko/20100101 Thunderbird/32.0

While building on Mac OS X, this code in src/callproc.c (line 1582ish):

#ifdef HAVE_NS
  if (data_dir == 0)
    data_dir == ns_etc_directory () != 0;
#endif

gives a warning:

cc   -c  -Demacs  -I. -I. -I../lib -I../lib                   -MMD -MF
deps/callproc.d -MP   -Wno-switch
-Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign  -g3
-O2  callproc.c

callproc.c:1582:14: warning: comparison between pointer and integer
('int' and 'const char *')
    data_dir == ns_etc_directory () != 0;
    ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~
callproc.c:1582:37: warning: inequality comparison result unused
[-Wunused-comparison]
    data_dir == ns_etc_directory () != 0;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~

2 warnings generated.

Maybe s/==/=/ ?

Looks like it was added in bzr r117829 (the huge alloca() patch).

-David

smime.p7s
Description: S/MIME Cryptographic Signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk
>
>
>
>
> Date: 
>
> Sun, 14 Sep 2014 10:24:43 +0200
>
>
>
>
> Hello.
>
> 14 sep 2014 kl. 07:55 skrev David Caldwell <address@hidden>:
>
> > 
> > While building on Mac OS X, this code in src/callproc.c (line 1582ish):
> > 
> > #ifdef HAVE_NS
> >  if (data_dir == 0)
> >    data_dir == ns_etc_directory () != 0;
> > #endif
> > 
> > gives a warning:
> > 
> > cc   -c  -Demacs  -I. -I. -I../lib -I../lib                   -MMD -MF
> > deps/callproc.d -MP   -Wno-switch
> > -Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign  -g3
> > -O2  callproc.c
> > 
> > callproc.c:1582:14: warning: comparison between pointer and integer
> > ('int' and 'const char *')
> >    data_dir == ns_etc_directory () != 0;
> >    ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~
> > callproc.c:1582:37: warning: inequality comparison result unused
> > [-Wunused-comparison]
> >    data_dir == ns_etc_directory () != 0;
> >    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> > 
> > 2 warnings generated.
> > 
> > Maybe s/==/=/ ?
> > 
> > Looks like it was added in bzr r117829 (the huge alloca() patch).
>
> An obvious typo, fixed now.  Thanks.
>
>         Jan D.
>
>
>
> --- End Message ---