[debbugs-tracker] bug#18189: closed (customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs)

[GNU bug Tracking System]

Your message dated Sun, 10 Aug 2014 02:57:43 +0300
with message-id <address@hidden>
and subject line Re: bug#18189: customized value of 
'vc-annotate-background-mode' is applied only after restarting Emacs
has caused the debbugs.gnu.org bug report #18189,
regarding customized value of 'vc-annotate-background-mode' is applied only 
after restarting Emacs
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18189: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18189
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs Date: Mon, 4 Aug 2014 15:18:06 +0200

To reproduce:

- customize the variable and toggle its value;

- observe that annotation buffers still look the same, even if you generate them anew;

- new variable value is only honored if you restart Emacs.

Ideally the value should be apply on-the-fly. But at least it should be applied if I hit 'C-x v g' after customizing the variable.

Paul

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs
>
>
>
>
> Date: 
>
> Sun, 10 Aug 2014 02:57:43 +0300
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu)
>
>
>
>
> >> `vc-annotate-background-mode' is defined before `vc-annotate-color-map'
> >> in the source file vc-annotate.el, so there is a cyclic dependency
> >> in these variables.  When I tried to provide it directly in the `defcustom'
> >
> > Usually that's a sign you need an :initialize as well as a :set, and/or
> > a :set-after.
>
> I don't see how :initialize and :set-after could be used
> to update the value of the dependent variable, and can't find
> a suitable example in the source code, so I just added a check
> for (boundp 'vc-annotate-color-map).
>
>
> --- End Message ---