[debbugs-tracker] bug#17769: closed (24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer.)

[GNU bug Tracking System]

Your message dated Thu, 19 Jun 2014 19:18:12 +0800
with message-id <address@hidden>
and subject line Re: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing 
a window that does not display  current-buffer.
has caused the debbugs.gnu.org bug report #17769,
regarding 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does 
not display current-buffer.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17769: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17769
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Date: Fri, 13 Jun 2014 15:59:33 +0900 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

Hi,

The attached patch prevents `rcirc-omit-mode' to call `recenter' when
`window-buffer' isn't the same as `current-buffer'.


If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c
C-o) then it will do the right thing.

If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we
don't need to `recenter' the buffer, because it will be done the next
time the user switch to the buffer with `rcirc-next-active-buffer'.

I'm not an RCIRC expert, but I don't think anything else is required.
WDYT?

0001-lisp-net-rcirc.el-rcirc-omit-mode-Do-not-recenter-if.patch
Description: Text Data

--
Daimrod/Greg

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display	current-buffer.
>
>
>
>
> Date: 
>
> Thu, 19 Jun 2014 19:18:12 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5)
>
>
>
>
> Fixed in 24.5.
>
> On 2014-06-14 01:08 +0900, Daimrod wrote:
> > I see, thanks for inputs.
> >
> > Here is an updated patch.
>
> Thanks for the patch.
>
> Leo
>
>
> --- End Message ---