--- Begin Message ---
|
Subject: |
[PATCH] grep: fix the different behaviour for a invalid sequence between KWset and DFA |
|
Date: |
Thu, 01 May 2014 00:02:19 +0900 |
Thare is different behaviour for a invalid sequence between KWset and DFA.
encode() { echo "$1" | tr ABC '\357\274\241'; }
encode ABC | env LC_ALL=en_US.utf8 src/grep "$(encode A)\|q"
encode ABC | env LC_ALL=en_US.utf8 src/grep -F "$(encode A)"
encode sABC | env LC_ALL=en_US.utf8 src/grep "a$(encode A)\|q"
encode sABC | env LC_ALL=en_US.utf8 src/grep -F "a$(encode A)"
We expect that all of them are same results, but only 4th returns 1 row.
This patch fixes it, changes all into 1 row returned.
Norihiro
patch.txt
Description: Text document
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#17376: [PATCH] grep: fix the different behaviour for a invalid sequence between KWset and DFA |
|
Date: |
Sun, 04 May 2014 19:41:29 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Thanks for that fix. I found a few glitches, mostly having to do with
storing WEOF in a wchar_t, which is not portable. There were also some
opportunities for simplification and clarification. I installed the
patch, and followed it up with the attached three patches. The second
patch is the only one that fixes any bugs.
0001-tests-improve-coverage-for-prefix-of-multibyte.patch
Description: Text document
0002-grep-simplify-and-fix-problems-with-KWset-DFA-agreem.patch
Description: Text document
0003-dfa-minor-simplification.patch
Description: Text document
--- End Message ---