[debbugs-tracker] bug#16912: closed ([PATCH] no longer use CSET for non-UTF8 locale in DFA engine)

[GNU bug Tracking System]

Your message dated Sun, 02 Mar 2014 23:07:41 -0800
with message-id <address@hidden>
and subject line Re: bug#16912: [PATCH] no longer use CSET for non-UTF8 locale 
in DFA engine
has caused the debbugs.gnu.org bug report #16912,
regarding [PATCH] no longer use CSET for non-UTF8 locale in DFA engine
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
16912: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16912
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] no longer use CSET for non-UTF8 locale in DFA engine Date: Sat, 01 Mar 2014 18:48:22 +0900

Package: grep
Tags: patch

I have overlooked the important thing about optimization by
trivial_case_ignore.  After optimization by trivial_case_ignore,
kwset engine can be used yet.  However, if remove trivial_case_ignore,
it's never used longer because kwsmusts does nothing when MB_CUR_MAX > 1
&& match_icase.

The patch reverts removal of trivial_case_ignore and fixes 200x slower
for non-UTF8 locales with another approach.  It always prefers CSET to
replacement to OR and no longer use CSET for non-UTF8 locales in DFA
engine.

It can also optimize by trivial_case_ignore and enables to speed-up >20x
for non-UTF8 locales. (I tested it with euc-jp)

Norihiro

patch.txt
Description: Binary data

tests.txt
Description: Binary data

--- End Message ---

--- Begin Message --- Subject: Re: bug#16912: [PATCH] no longer use CSET for non-UTF8 locale in DFA engine Date: Sun, 02 Mar 2014 23:07:41 -0800 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 Thanks, I tweaked the ChangeLog entries a bit and pushed that. I also pushed the attached patch, which fixes some new bugs and some bugs that were reintroduced by the revival of trivial_case_ignore. I wish we didn't need that function, as it is a bit of a kludge.

0001-grep-fix-some-unlikely-bugs-in-trivial_case_ignore.patch
Description: Text document

--- End Message ---