[debbugs-tracker] bug#16011: closed ([patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer)

[GNU bug Tracking System]

Your message dated Tue, 03 Dec 2013 10:06:21 +0900
with message-id <address@hidden>
and subject line Re: bug#16011: [patch] 24.3.50; 
message-send-mail-with-sendmail kills useful error message buffer
has caused the debbugs.gnu.org bug report #16011,
regarding [patch] 24.3.50; message-send-mail-with-sendmail kills useful error 
message buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
16011: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16011
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer
>
>
>
>
> Date: 
>
> Sat, 30 Nov 2013 00:38:25 -0800
>
>
>
>
> Hi, 
>
> On error, message-send-mail-with-sendmail pops to the error message
> buffer with an obvious intention for the user to see it. But then kills
> the buffer.
>
> Consequently the user sees only a completely useless, emacs generated
> message like:
>
>    error: "Sending...failed with exit value 78" 
>
>
>    Vitalie
>
>
> >From 757150148ebd6ac841133010b31c807191bf448b Mon Sep 17 00:00:00 2001
> From: Vitalie Spinu <address@hidden>
> Date: Sat, 30 Nov 2013 00:26:42 -0800
> Subject: [PATCH] message-send-mail-with-sendmail: don't kill error buffer on
>  error
>
> ---
>  lisp/gnus/message.el | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
> index b7d0ada..f96cd7a 100644
> --- a/lisp/gnus/message.el
> +++ b/lisp/gnus/message.el
> @@ -4739,7 +4739,9 @@ that instead."
>                             (list resend-to-addresses)
>                           '("-t"))))))
>             (unless (or (null cpr) (and (numberp cpr) (zerop cpr)))
> -              (if errbuf (pop-to-buffer errbuf))
> +              (when errbuf
> +                (pop-to-buffer errbuf)
> +                (setq errbuf nil))
>               (error "Sending...failed with exit value %d" cpr)))
>           (when message-interactive
>             (with-current-buffer errbuf
> -- 
> 1.8.1.2
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#16011: [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer
>
>
>
>
> Date: 
>
> Tue, 03 Dec 2013 10:06:21 +0900
>
>
>
>
> User-agent: 
>
> Gnus/5.130008 (真 Gnus v0.8) Emacs/24.3.50 (i686-pc-cygwin)
>
>
>
>
> Vitalie Spinu wrote:
> > On error, message-send-mail-with-sendmail pops to the error message
> > buffer with an obvious intention for the user to see it. But then kills
> > the buffer.
>
> Applied the patch to Emacs trunk and Gnus master.  Thanks.
>
>
> --- End Message ---