emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#15967: closed (24.3.50; [PATCH] eww: use eww-brows


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#15967: closed (24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened)
Date: Tue, 26 Nov 2013 20:10:10 +0000

Your message dated Tue, 26 Nov 2013 15:10:31 -0500
with message-id <address@hidden>
and subject line Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use 
eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; 
[PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] 
eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current 
URL is not entered automatically, after ewwstarts.s.
has caused the debbugs.gnu.org bug report #15967,
regarding 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list 
is opened
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
15967: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15967
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened Date: Mon, 25 Nov 2013 00:15:52 +0900 User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3
Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it
doesn't save current URL in eww-history.

Signed-off-by: Kenjiro NAKAYAMA <address@hidden>

        * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'.

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 6f09d86..738136b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1065,7 +1065,7 @@ The browser to used is specified by the 
`shr-external-browser' variable."
     ;; just let it remain.
     (ignore-errors
       (delete-window))
-    (eww (plist-get bookmark :url))))
+    (eww-browse-url (plist-get bookmark :url))))

 (defun eww-next-bookmark ()
   "Go to the next bookmark in the list."
--
1.8.3.1



--- End Message ---
--- Begin Message --- Subject: Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Date: Tue, 26 Nov 2013 15:10:31 -0500 User-agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux)
On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <address@hidden> wrote: 

KN> I consolidated the patches, please include the patch if appreciated.

OK; done.  I changed "add bookmark this page?" to "bookmark this page?"
but otherwise had no issues.

Thanks!
Ted


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]