[debbugs-tracker] bug#15938: closed (diff-mode mishandles diff-default-read-only )

[GNU bug Tracking System]

Your message dated Fri, 22 Nov 2013 21:57:03 -0500
with message-id <address@hidden>
and subject line Re: bug#15938: diff-mode mishandles diff-default-read-only
has caused the debbugs.gnu.org bug report #15938,
regarding diff-mode mishandles diff-default-read-only 
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
15938: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15938
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> diff-mode mishandles diff-default-read-only 
>
>
>
>
> Date: 
>
> Wed, 20 Nov 2013 19:47:29 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
>
>
>
>
>         In addition to making the -*- Diff -*- buffers read-only when
>         diff-default-read-only is non-nil, diff-mode also makes such
>         buffers /writable/ when diff-default-read-only is nil, while per
>         the documentation, I’d expect for diff-mode to have no effect on
>         buffer-read-only in this latter case.
>
>         Please consider the patch below, which seems to fix the issue.
>
> --- diff-mode.el.~1~
> +++ diff-mode.el        2013-11-20 19:42:41.000000000 +0000
> @@ -1366,7 +1366,8 @@ (define-derived-mode diff-mode fundamental-mode "Diff"
>  
>    (diff-setup-whitespace)
>  
> -  (setq buffer-read-only diff-default-read-only)
> +  (when diff-default-read-only
> +    (setq buffer-read-only t))
>    ;; setup change hooks
>    (if (not diff-update-on-the-fly)
>        (add-hook 'write-contents-functions 'diff-write-contents-hooks nil t)
>
> -- 
> FSF associate member #7257
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#15938: diff-mode mishandles diff-default-read-only
>
>
>
>
> Date: 
>
> Fri, 22 Nov 2013 21:57:03 -0500
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Version: 24.4
>
> Thanks; applied.
>
> (BTW, we'd probably need a copyright assignment to accept anything more
> than 2-3 lines more from you in future. So maybe think about starting
> that process if you expect to contribute more.)
>
>
> --- End Message ---