emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#15067: closed (24.3.50; configure does not allow f


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#15067: closed (24.3.50; configure does not allow for sound support without ALSA)
Date: Sat, 31 Aug 2013 19:56:02 +0000

Your message dated Sat, 31 Aug 2013 15:55:27 -0400
with message-id <address@hidden>
and subject line Re: bug#15067: 24.3.50; configure does not allow for sound 
support without ALSA
has caused the debbugs.gnu.org bug report #15067,
regarding 24.3.50; configure does not allow for sound support without ALSA
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
15067: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15067
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.3.50; configure does not allow for sound support without ALSA Date: Sat, 10 Aug 2013 12:13:57 +0200
Tags: patch

In GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, Motif Version 2.3.4)
 of 2013-08-02 on juno
Bzr revision: address@hidden
Windowing system distributor `The X.Org Foundation', version
 11.0.11402901
System Description:     NAME=Gentoo

After the 2013-07-27 change to configure.ac, --with-sound will accept
option values (yes, no, ossaudio, alsa). However, it is not possible
to enable sound support but prevent autodetection of ALSA.
For example, when configuring --with-sound=yes on a GNU/Linux system,
ALSA will be enabled when it is found.

The patch below adds a new value --with-sound=voxware that will enable
sound but not ALSA, i.e. src/sound.c will then use the /dev/dsp device
of OSS.

(I'd have preferred the name "oss" over "voxware", but there already
is "ossaudio" and I think having "oss" along with it would be too
confusing. Also src/sound.c refers to the driver as Voxware and
functions are called vox_init() etc. But feel free to change it to
"oss" if you think that confusion is not an issue.)


--- emacs-orig/ChangeLog
+++ emacs/ChangeLog
@@ -1,3 +1,9 @@
+2013-08-10  Ulrich Müller  <address@hidden>
+
+       * configure.ac: Allow for --with-sound=voxware that will enable
+       sound but otherwise disable ALSA. This will use the OSS device,
+       typically /dev/dsp, for sound output.
+
 2013-08-10  Eli Zaretskii  <address@hidden>
 
        * configure.ac: Define and substitute UPDATE_MANIFEST.
--- emacs-orig/configure.ac
+++ emacs/configure.ac
@@ -142,12 +142,12 @@
     AC_DEFINE_UNQUOTED(MAILHOST, ["$withval"], [String giving fallback POP 
mail host.]))
 
 AC_ARG_WITH([sound],[AS_HELP_STRING([--with-sound=VALUE],
-  [compile with sound support (VALUE one of: yes, ossaudio, alsa, no;
+  [compile with sound support (VALUE one of: yes, ossaudio, alsa, voxware, no;
 default yes).  Only for GNU/Linux, FreeBSD, NetBSD, MinGW.])],
   [ case "${withval}" in
-      yes|no|ossaudio|alsa) val=$withval ;;
+      yes|no|ossaudio|alsa|voxware) val=$withval ;;
       *) AC_MSG_ERROR([`--with-sound=$withval' is invalid;
-this option's value should be `yes', `no', `ossaudio', or `alsa'.])
+this option's value should be `yes', `no', `ossaudio', `alsa', or `voxware'.])
       ;;
     esac
     with_sound=$val
@@ -1274,6 +1274,9 @@
     #include <windows.h>
     #endif
     ])
+  test "${with_sound}" = "voxware" && test "${have_sound_header}" != "yes" && \
+    AC_MSG_ERROR([OSS/Voxware sound support requested but not found.])
+
   if test "${with_sound}" = "ossaudio" || test "${with_sound}" = "yes"; then
     # Emulation library used on NetBSD.
     AC_CHECK_LIB(ossaudio, _oss_ioctl, LIBSOUND=-lossaudio, LIBSOUND=)



--- End Message ---
--- Begin Message --- Subject: Re: bug#15067: 24.3.50; configure does not allow for sound support without ALSA Date: Sat, 31 Aug 2013 15:55:27 -0400 User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
Version: 24.4

Applied.

I think no-one is going to know what these options mean without reading
configure.ac, but I don't expect (m)any people will use them apart from
the people who reported these issues in the first place.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]