[debbugs-tracker] bug#13981: closed (24.3.50; Incorrect declaration of image_background)

[GNU bug Tracking System]

Your message dated Sun, 17 Mar 2013 10:36:25 -0400
with message-id <address@hidden>
and subject line Re: bug#13981: 24.3.50; Incorrect declaration of 
image_background
has caused the debbugs.gnu.org bug report #13981,
regarding 24.3.50; Incorrect declaration of image_background
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
13981: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13981
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 24.3.50; Incorrect declaration of image_background Date: Sat, 16 Mar 2013 15:57:09 -0400 User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 image_background() is declared in dispextern.h with a return type of `unsigned long'. But it is defined in image.c with a return type of RGB_PIXEL_COLOR, where the latter is a platform-dependent macro defined in image.c.

By luck, this doesn't cause any problems in the currently-supported platforms. But it will cause problems in the cygw32 build on 64-bit Cygwin (which is currently under development). The attached patch fixes this by moving the definition of RGB_PIXEL_COLOR to dispextern.h and changing the return type in the declaration.

OK to apply?

Ken

image_background.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#13981: 24.3.50; Incorrect declaration of image_background
>
>
>
>
> Date: 
>
> Sun, 17 Mar 2013 10:36:25 -0400
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (Windows NT 6.1; WOW64;	rv:17.0) Gecko/20130107 Thunderbird/17.0.2
>
>
>
>
> On 3/16/2013 11:48 PM, Eli Zaretskii wrote:
> > > Date: Sat, 16 Mar 2013 15:57:09 -0400
> > > From: Ken Brown <address@hidden>
> > > OK to apply?
> >
> > Yes, but please move the definition of RGB_PIXEL_COLOR so it is just
> > before the prototype of image_background, since that is its only user.
>
> Done as bzr revision 112064.  I'm closing the bug.
>
> Ken
>
>
> --- End Message ---