[debbugs-tracker] bug#5600: closed (23.1; etags don't tag (defvar foo) declaration)

[GNU bug Tracking System]

Your message dated Sun, 02 Dec 2012 09:49:10 +0800
with message-id <address@hidden>
and subject line Re: bug#5600: 23.1; etags don't tag (defvar foo) declaration
has caused the debbugs.gnu.org bug report #5600,
regarding 23.1; etags don't tag (defvar foo) declaration
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
5600: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5600
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 23.1; etags don't tag (defvar foo) declaration Date: Fri, 19 Feb 2010 11:00:40 +1100 User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

It'd be good if etags didn't tag defvar declaration forms, only actual
variable definitions.  For example it picks up

    (defvar message-indent-citation-function)

in longlines.el ahead of that variable's actual definition in
message.el, so M-. of that var goes to longlines.el first.

Perhaps something along the lines below.

I found the tripe-negative of while(!noninname) hard to follow and
thought a skip_name() could be clearer.  It might be shared by
Perl_functions, PHP_functions and Makefile_functions.

2010-02-18  Kevin Ryde  <address@hidden>

        * etags.c (Lisp_functions): Don't tag "(defvar foo)" declarations.
        (skip_name): New helper.

etags.c.defvar.diff
Description: Text Data

In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' 
'--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' 
'--localstatedir=/var/lib' '--infodir=/usr/share/info' 
'--mandir=/usr/share/man' '--with-pop=yes' 
'--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim'
 '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 
'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g 
-O2' 'LDFLAGS=-g' 'CPPFLAGS=''

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#5600: 23.1; etags don't tag (defvar foo) declaration
>
>
>
>
> Date: 
>
> Sun, 02 Dec 2012 09:49:10 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
>
>
>
>
> Kevin Ryde <address@hidden> writes:
>
> > Sounds likely.  I didn't know about that option, new diff below.
> > I suppose it could tag `declare-function' and the like too, but start
> > with untagging the defvar ones.
>
> I've now committed this patch to trunk.  Thanks.
>
>
> --- End Message ---