[debbugs-tracker] bug#11791: closed (recheck and compilation error)

[GNU bug Tracking System]

Your message dated Sat, 30 Jun 2012 20:39:52 +0200
with message-id <address@hidden>
and subject line Re: bug#11791: recheck and compilation error
has caused the debbugs.gnu.org bug report #11791,
regarding recheck and compilation error
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
11791: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11791
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: recheck and compilation error Date: Tue, 26 Jun 2012 21:56:58 +1000 User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20

Hello automakers,

I've noticed the following behavior from 'make recheck'.

If I run 'make check' and one test fails
$ make check
...
FAIL: foo.test

I modify the test
$ edit foo.c
and rerun the test suite with
$ make recheck -k
foo.c:1: error: parse error before '}' token
make[1]: *** [foo.o] Error 1
make[1]: Target `test-suite.log' not remade because of errors.
make: *** [recheck] Error 2

which is now interrupted as I introduced a compilation error. If I now try edit the test again and rerun test suite with

$ make recheck -k
I get
# TOTAL: 0
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0

that is, the failed test is not rerun. I suppose the reason is that it was never run last time and that there exist no trs file, but this is IMHO suboptimal and unexpected. I would expect that make recheck also includes tests that failed due to compilation problems or at least tests that failed last time they were run.

Please find a script attached illustrating the behavior.

This is with automake 1.12.

Cheers,
Peter

--
Peter Johansson

recheck.sh
Description: Bourne shell script

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#11791: recheck and compilation error
>
>
>
>
> Date: 
>
> Sat, 30 Jun 2012 20:39:52 +0200
>
>
>
>
> Reference: <http://debbugs.gnu.org/11791>
>
> On 06/27/2012 03:08 PM, Stefano Lattarini wrote:
> >
> > I agree.  The attached patch should solve the issue.   It's more ugly
> > than I'd like, but this bug is annoying enough to make such ugliness
> > acceptable.  I will push (to maint) in a couple of days if there are
> > no objections.
> > 
> Pushed now.  I'm thus closing this bug report.
>
> Regards,
>   Stefano
>
>
> --- End Message ---