[debbugs-tracker] bug#11725: closed (24.1; confirm-nonexistent-file-or-buffer with after-completion value)

[GNU bug Tracking System]

Your message dated Sat, 23 Jun 2012 00:50:14 -0400
with message-id <address@hidden>
and subject line Re: bug#11725: 24.1; confirm-nonexistent-file-or-buffer with 
after-completion value
has caused the debbugs.gnu.org bug report #11725,
regarding 24.1; confirm-nonexistent-file-or-buffer with after-completion value
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
11725: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11725
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.1; confirm-nonexistent-file-or-buffer with after-completion value
>
>
>
>
> Date: 
>
> Sat, 16 Jun 2012 19:14:18 +0200
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64;	rv:13.0) Gecko/20120616 Thunderbird/13.0.1
>
>
>
>
> Using the default value of "after-completion" of the variable
> "confirm-nonexistent-file-or-buffer" never asks for confirmation.
>
> I made a git bisect, the first bad commit is:
>
>     commit 064b509639208159ca7c619bccf319aef7950146
>     Author: Stefan Monnier <address@hidden>
>     Date: Mon Mar 12 00:10:59 2012 -0400
>
>         * lisp/minibuffer.el (minibuffer-complete): Don't get confused 
> when the
>         function is run twice via different commands.
>         (complete-with-action): Fix docstring.
>
> Steps to reproduce after bad commit:
>
> 1) made two files in bash:
> $ cd /tmp
> $ touch almafa almacsutka
>
> 2) open emacs
> C-x C-f /tmp/al[TAB][RET]
>
> [TAB] completes to /tmp/alma, then after pressing [RET], a new file
> called alma is open, instead of asking for confirmation.
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#11725: 24.1;	confirm-nonexistent-file-or-buffer with after-completion value
>
>
>
>
> Date: 
>
> Sat, 23 Jun 2012 00:50:14 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)
>
>
>
>
> Version: 24.2
>
> > 1) made two files in bash:
> > $ cd /tmp
> > $ touch almafa almacsutka
> > 2) open emacs
> > C-x C-f /tmp/al[TAB][RET]
> > [TAB] completes to /tmp/alma, then after pressing [RET], a new file
> > called alma is open, instead of asking for confirmation.
>
> Thanks, I've installed the patch below on the emacs-24 branch, which
> should fix the problem.
>
>
>         Stefan
>
>
> --- lisp/minibuffer.el  2012-04-07 08:12:04 +0000
> +++ lisp/minibuffer.el  2012-06-23 04:47:36 +0000
> @@ -892,7 +892,8 @@
>          (completion--cache-all-sorted-completions (cdr all)))))))
>  
>  (defvar minibuffer-confirm-exit-commands
> -  '(minibuffer-complete minibuffer-complete-word PC-complete PC-complete-word)
> +  '(completion-at-point minibuffer-complete
> +    minibuffer-complete-word PC-complete PC-complete-word)
>    "A list of commands which cause an immediately following
>  `minibuffer-complete-and-exit' to ask for extra confirmation.")
>  
>
>
>
> --- End Message ---