[debbugs-tracker] bug#11547: closed (24.0.96; Was a line accidentally commented out in callproc.c?)

[GNU bug Tracking System]

Your message dated Thu, 24 May 2012 07:24:36 -0400
with message-id <address@hidden>
and subject line Re: bug#11547: 24.0.96; Was a line accidentally commented out 
in callproc.c?
has caused the debbugs.gnu.org bug report #11547,
regarding 24.0.96; Was a line accidentally commented out in callproc.c?
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
11547: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11547
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.0.96; Was a line accidentally commented out in callproc.c?
>
>
>
>
> Date: 
>
> Wed, 23 May 2012 11:03:21 -0400
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (Windows NT 6.1; WOW64;	rv:12.0) Gecko/20120428 Thunderbird/12.0.1
>
>
>
>
> In the course of trying to debug a Cygwin crash, I noticed that line 643 
> of callproc.c is commented out.  This was done in bzr revision 103252, 
> and it seems pretty clear from the context of that change that it was 
> done by accident:
>
> revno: 103252
> committer: Jan D <address@hidden>
> branch nick: trunk
> timestamp: Sun 2011-02-13 12:28:42 +0100
> message:
>   * callproc.c (Fcall_process):
>   * process.c (create_process): Replace Gtk with GConf in SIGPIPE
>   comment.
> modified:
>   src/ChangeLog
>   src/callproc.c
>   src/process.c
> diff:
> === modified file 'src/ChangeLog'
> --- src/ChangeLog       2011-02-13 00:16:28 +0000
> +++ src/ChangeLog       2011-02-13 11:28:42 +0000
> @@ -1,3 +1,9 @@
> +2011-02-13  Jan Djärv  <address@hidden>
> +
> +       * callproc.c (Fcall_process):
> +       * process.c (create_process): Replace Gtk with GConf in SIGPIPE
> +       comment.
> +
>  2011-02-12  Martin Rudalics  <address@hidden>
>
>         * window.c (select_window): Check inhibit_point_swap argument when
>
> === modified file 'src/callproc.c'
> --- src/callproc.c      2011-02-12 18:53:24 +0000
> +++ src/callproc.c      2011-02-13 11:28:42 +0000
> @@ -559,9 +559,9 @@
>          setpgrp (pid, pid);
>  #endif /* USG */
>
> -       /* GTK causes us to ignore SIGPIPE, make sure it is restored
> +       /* GConf causes us to ignore SIGPIPE, make sure it is restored
>            in the child.  */
> -       signal (SIGPIPE, SIG_DFL);
> +       //signal (SIGPIPE, SIG_DFL);
>  #ifdef HAVE_WORKING_VFORK
>         sigprocmask (SIG_SETMASK, &procmask, 0);
>  #endif
>
> === modified file 'src/process.c'
> --- src/process.c       2011-02-12 18:53:24 +0000
> +++ src/process.c       2011-02-13 11:28:42 +0000
> @@ -2056,7 +2056,7 @@
>
>         signal (SIGINT, SIG_DFL);
>         signal (SIGQUIT, SIG_DFL);
> -       /* GTK causes us to ignore SIGPIPE, make sure it is restored
> +       /* GConf causes us to ignore SIGPIPE, make sure it is restored
>            in the child.  */
>         signal (SIGPIPE, SIG_DFL);
>
>
> I don't understand the code well enough to know how critical this is. 
> The comment preceding that line suggests that it could be a problem for 
> a build with GConf support.
>
> Ken
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#11547: 24.0.96; Was a line accidentally commented out in	callproc.c?
>
>
>
>
> Date: 
>
> Thu, 24 May 2012 07:24:36 -0400
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (Windows NT 6.1; WOW64;	rv:12.0) Gecko/20120428 Thunderbird/12.0.1
>
>
>
>
> > Please go ahead and install it on the emacs-24 branch (only: not on the
> > trunk).
>
> Installed as bzr revision 108013 on the emacs-24 branch; I'm closing the 
> bug.
>
> Ken
>
>
>
> --- End Message ---