|
From: | GNU bug Tracking System |
Subject: | [Emacs-bug-tracker] bug#8089: closed (Eshell remote files fix (patch)) |
Date: | Tue, 22 Feb 2011 05:55:02 +0000 |
Your message dated Tue, 22 Feb 2011 06:54:45 +0100 with message-id <address@hidden> and subject line Re: bug#8089: Eshell remote files fix (patch) has caused the GNU bug report #8089, regarding Eshell remote files fix (patch) to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 8089: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8089 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: Eshell remote files fix (patch) Date: Sun, 20 Feb 2011 22:02:45 +0200 The following currently fails in Eshell:$ sudo bzgrep # Or any shell script in PATH/bin/sh: /sudo:address@hidden:/usr/bin/bzgrep: No such file or directoryThis is apparently so because eshell/sudo translates that to a Tramp remote location, but eshell-external-command fails to handle it as a remote command. It instead passes the default-directory containing Tramp syntax directly to the command (shell script), which obviously fails as it doesn't understand Tramp syntax. The patch below fixes this issue. (Was there any specific reason for earlier only considering "ftp" being remote, instead of all Tramp methods?)--- esh-ext.el.orig 2011-02-18 20:57:50.000000000 +0200+++ esh-ext.el 2011-02-18 20:58:12.000000000 +0200@@ -203,7 +203,7 @@(defun eshell-external-command (command args)"Insert output from an external COMMAND, using ARGS."(setq args (eshell-stringify-list (eshell-flatten-list args)))- (if (string-equal (file-remote-p default-directory 'method) "ftp")+ (if (file-remote-p default-directory)(eshell-remote-command command args))(let ((interp (eshell-find-interpreter command)))(assert interp)
--- End Message ---
--- Begin Message ---Subject: Re: bug#8089: Eshell remote files fix (patch) Date: Tue, 22 Feb 2011 06:54:45 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Seppo Sade <address@hidden> writes: > The following currently fails in Eshell: > > $ sudo bzgrep # Or any shell script in PATH > /bin/sh: /sudo:address@hidden:/usr/bin/bzgrep: No such file or > directory > > This is apparently so because eshell/sudo translates that to a Tramp > remote location, but eshell-external-command fails to handle it as a > remote command. It instead passes the default-directory containing > Tramp syntax directly to the command (shell script), which obviously > fails as it doesn't understand Tramp syntax. The patch below fixes > this issue. Thanks for the report. I've applied your patch to the trunk (aka Emacs 24). > (Was there any specific reason for earlier only considering "ftp" > being remote, instead of all Tramp methods?) Historical reasons. Originally, eshell used ange-ftp for remote connections. Best regards, Michael.
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |