--- Begin Message ---
|
Subject: |
24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly |
|
Date: |
Wed, 28 Jul 2010 02:15:32 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Found by --enable-checking.
(defvar foo nil)
(defvaralias 'bar 'foo)
(make-local-variable 'bar)
(local-variable-p 'bar)
returns nil or may crash if checking is enabled. (trunk)
2010-07-27 Johan Bockg=e5rd <address@hidden>
* data.c (Flocal_variable_p): Handle variable aliases correctly.
diff --git a/src/data.c b/src/data.c
index 152a888..b78a665 100644
--- a/src/data.c
+++ b/src/data.c
@@ -1865,6 +1865,7 @@ BUFFER defaults to the current buffer. */)
Lisp_Object tail, elt, tmp;
struct Lisp_Buffer_Local_Value *blv = SYMBOL_BLV (sym);
XSETBUFFER (tmp, buf);
+ XSETSYMBOL (variable, sym); /* Update in case of aliasing. */
for (tail = buf->local_var_alist; CONSP (tail); tail = XCDR (tail))
{
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly |
|
Date: |
Tue, 03 Aug 2010 19:13:49 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Juanma Barranquero <address@hidden> writes:
> On Wed, Jul 28, 2010 at 02:15, Johan Bockg=e5rd <address@hidden> wrote:
>
>> 2010-07-27 Johan Bockg=e5rd <address@hidden>
>>
>> * data.c (Flocal_variable_p): Handle variable aliases correctly.
>>
>> + XSETSYMBOL (variable, sym); /* Update in case of aliasing. */
>
> If you think this is the right fix, please install it.
Done.
--- End Message ---