[Emacs-bug-tracker] bug#6515: closed (24.0.50; unneeded let-binded variable in bookmark.el)

[GNU bug Tracking System]

Your message dated Sun, 27 Jun 2010 14:04:54 -0400
with message-id <address@hidden>
and subject line Re: 24.0.50; unneeded let-binded variable in bookmark.el
has caused the GNU bug report #6515,
regarding 24.0.50; unneeded let-binded variable in bookmark.el
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
6515: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.0.50; unneeded let-binded variable in bookmark.el
>
>
>
>
> Date: 
>
> Fri, 25 Jun 2010 23:13:20 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux)
>
>
>
>
> Hi,
> bookmark-bmenu-switch-other-window
> bookmark-bmenu-2-window
> bookmark-bmenu-other-window
>
> (let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed?
>
> Indeed it's not needed, worst, it anhile effect of global
> bookmark-automatically-show-annotations
>
> Thierry.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: 24.0.50; unneeded let-binded variable in bookmark.el
>
>
>
>
> Date: 
>
> Sun, 27 Jun 2010 14:04:54 -0400
>
>
>
>
> > Find attached a bugfix for bug #6515
> > (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review.
> >
> > Imho, the bug report is valid. I don't think the code in question should
> > override globally set variable bookmark-automatically-show-annotations.
> > Therefore, the let variables were removed.
>
> Yes, checked in, thanks.
>
>
> --- End Message ---