--- Begin Message ---
Subject: |
24.0.50; completions-format should not have a `nil' choice |
Date: |
Fri, 18 Jun 2010 13:17:50 -0700 |
This is the definition:
(defcustom completions-format nil
"Define the appearance and sorting of completions.
If the value is `vertical', display completions sorted vertically
in columns in the *Completions* buffer.
If the value is `horizontal' or nil, display completions sorted
horizontally in alphabetical order, rather than down the screen."
:type '(choice (const nil) (const horizontal) (const vertical))
:group 'minibuffer
:version "23.2")
There is no reason for the `nil' choice. Please remove it and make the
default value `horizontal'. Occam's razor (KISS) and clarity for users
argue for this.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-06-14 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#6459: 24.0.50; completions-format should not have a `nil' choice |
Date: |
Fri, 25 Jun 2010 00:54:08 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) |
>> >> There is no reason for the `nil' choice. Please remove it
>> >> and make the default value `horizontal'. Occam's razor
>> >> (KISS) and clarity for users argue for this.
>> >
>> > We could remove nil from the docstring and from :type, and change
>> > the default value to `horizontal', but I'd still treat nil as
>> > `horizontal' internally for compatibility.
This is changed now.
> I don't have a big problem with that. But what "compatibility" is gained?
> Compatibility of what with what? This is a new variable.
>
>> Since this is a new defcustom woulddn't it be better to not let nil be
>> a valid value? That may catch some problems and the backward
>> compatibilities are not likely to be big.
>
> I agree with Lennart here. KISS. I see no reason for nil. I am unaware of any
> backward compatibility issue for this variable.
I don't want to completely break the *Completions* buffer with
an unadvertized value. So currently I left `horizontal' as a
catch-all case in the implementation.
--
Juri Linkov
http://www.jurta.org/emacs/
--- End Message ---