--- Begin Message ---
Subject: |
[PATCH] cp: treat selinux warnings consistently |
Date: |
Tue, 13 Apr 2010 13:14:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
I noticed some inconsistencies in how ENOTSUP errors were handled by cp.
$ dd bs=1M count=10 if=/dev/zero of=t.vfat
$ mkfs.vfat t.vfat
$ mkdir m.vfat
$ sudo mount -o loop t.vfat m.vfat
$ ./src/cp --preserve=all a m.vfat/
./src/cp: setting attribute `user.foo' for `user.foo': Permission denied
./src/cp: setting attribute `user.foo2' for `user.foo2': Permission denied
./src/cp: setting attribute `security.capability' for `security.capability':
Operation not permitted
./src/cp: preserving permissions for `m.vfat/a': Operation not supported
$ sudo ./src/cp --preserve=all a m.vfat/a
./src/cp: failed to set the security context of `m.vfat/a' to
`system_u:object_r:user_home_t:s0': Operation not supported
./src/cp: failed to preserve ownership for `m.vfat/a': Operation not permitted
Notice how one gets "Operation not supported" when the target exists.
The attached should fix it up.
cheers,
Pádraig.
cp-enotsup-existing.diff
Description: Text Data
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#5940: [PATCH] cp: treat selinux warnings consistently |
Date: |
Wed, 14 Apr 2010 00:58:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 13/04/10 13:14, Pádraig Brady wrote:
> I noticed some inconsistencies in how ENOTSUP errors were handled by cp.
>
> The attached should fix it up.
I've just pushed this.
cheers,
Pádraig
--- End Message ---