[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Duplicity-talk] Fwd: AssertionError on every attempt

From: Rupert Levene
Subject: Re: [Duplicity-talk] Fwd: AssertionError on every attempt
Date: Wed, 10 Jun 2015 16:49:53 +0100

OK, log.Warn should be changed to log.FatalError, I guess.

To make _delete remove all files, the simplest way might be

    def _delete(self, filename):
        flist = self.FilesList(filename)
        for f in flist:

Note that if filename=None is passed then this would delete all files!
Maybe this is worth checking for explicitly...


On 10 June 2015 at 15:56,  <address@hidden> wrote:
> On 10.06.2015 14:43, Rupert Levene wrote:
>> Here's a revised pydrivebackend.py. The changes are hopefully:
>> (1) querying on individual filenames where possible, which is much
>> faster than the old method
>> (2) warning if a filename used by duplicity is shared by several files
>> in the backup folder
>> (3) overwrite on upload if there is (at least one) existing file with
>> the same filename
>> (4) deletion of a non-existing file will do nothing; I don't know what
>> the old code would have done.
> looks good.
> not sure about (2) which might probably work, but probably is error, so i'd 
> rather had a fatal error thrown and the user deal with it than silently use 
> the first listed. who guarantees that google always returns the same file 
> first?
> wrt. (4) afair most backends ignore deletion problems, maybe log warn about 
> them only. but as we've now established that there is a possibility of 
> multiple instances on the backend, the delete routine should probably try to 
> delete all off them, no?
> ..ede/duply.net
> _______________________________________________
> Duplicity-talk mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/duplicity-talk

reply via email to

[Prev in Thread] Current Thread [Next in Thread]